-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add improvements for varnish vcl files #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add improvements for varnish vcl files #2028
Conversation
Hi, I have created this PR to improve the varnish configuration a little bit and fix some issues. I don't have varnish 3 at the moment, so I did not add the same configuration to the Varnish 3 files, because I can't test it. This PR is for #1575
Hi @nagno you need also to accept the CLA otherwise we can't use your PR. |
Hi @daim2k5, I tried to sign it at least 4 times since I submitted the PR. I'm happy to sign it, but it not works for some reason :( |
Hi @nagno thanks for the information i try to forward to a person that can maybe help with that ;-) |
@daim2k5: Perfect, thanks! :) |
@nagno please one more time because CLA service crashed ;-) |
@daim2k5: unfortunately it still not works :( |
Sorry @nagno, we're working on it. Thanks for helping us. |
Update: we've resolved the issue of the crashed CLA monitor, but the PRs submitted while it was down are stuck. We're working to unstick them (Ref CICD-1981). Sorry for the friction, and thanks for understanding as we get this new process sorted out. |
Hi @benmarks, |
Looks like we're resolved, thanks to internal team effort. @daim2k5, do your thing! |
Internal ticket: MAGETWO-49876 |
- Revised comments added by contributor.
- Added jpeg to filtered list.
@nagno Your Pull Request merged to develop branch. Thank you for contribution! |
Hi,
I have created this PR to improve the varnish configuration a little bit and fix some issues.
I don't have varnish 3 at the moment, so I did not add the same configuration to the Varnish 3
files, because I can't test it.
This PR is for #1575