Skip to content

Add improvements for varnish vcl files #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Add improvements for varnish vcl files #2028

merged 1 commit into from
Mar 3, 2016

Conversation

nagno
Copy link

@nagno nagno commented Oct 5, 2015

Hi,

I have created this PR to improve the varnish configuration a little bit and fix some issues.
I don't have varnish 3 at the moment, so I did not add the same configuration to the Varnish 3
files, because I can't test it.

This PR is for #1575

Hi,

I have created this PR to improve the varnish configuration a little bit and fix some issues.
I don't have varnish 3 at the moment, so I did not add the same configuration to the Varnish 3
files, because I can't test it.

This PR is for #1575
@daim2k5
Copy link
Contributor

daim2k5 commented Nov 6, 2015

Hi @nagno you need also to accept the CLA otherwise we can't use your PR.

@nagno
Copy link
Author

nagno commented Nov 6, 2015

Hi @daim2k5,

I tried to sign it at least 4 times since I submitted the PR.
It always displays the successful message, but it is still not appears as signed. This was my last attempt from 2 minutes ago: https://nimbus.everhelper.me/client/notes/share/323299/6aDViGBJltvnWuxVA5irNxLyVdEv8SMe/

I'm happy to sign it, but it not works for some reason :(

@daim2k5
Copy link
Contributor

daim2k5 commented Nov 6, 2015

Hi @nagno thanks for the information i try to forward to a person that can maybe help with that ;-)

@nagno
Copy link
Author

nagno commented Nov 6, 2015

@daim2k5: Perfect, thanks! :)

@daim2k5
Copy link
Contributor

daim2k5 commented Nov 8, 2015

@nagno please one more time because CLA service crashed ;-)

@nagno
Copy link
Author

nagno commented Nov 8, 2015

@daim2k5: unfortunately it still not works :(
I got the same "thank you" page, but on github it is still reported as not signed.

@benmarks
Copy link
Contributor

benmarks commented Nov 8, 2015

Sorry @nagno, we're working on it. Thanks for helping us.

@benmarks
Copy link
Contributor

benmarks commented Nov 9, 2015

Update: we've resolved the issue of the crashed CLA monitor, but the PRs submitted while it was down are stuck. We're working to unstick them (Ref CICD-1981). Sorry for the friction, and thanks for understanding as we get this new process sorted out.

@nagno
Copy link
Author

nagno commented Nov 9, 2015

Hi @benmarks,
Thanks for the update! I can re-submit the PR if that helps.

@benmarks
Copy link
Contributor

benmarks commented Nov 9, 2015

Looks like we're resolved, thanks to internal team effort. @daim2k5, do your thing!

@dsikkema-magento
Copy link
Contributor

Internal ticket: MAGETWO-49876

@dsikkema-magento dsikkema-magento added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 26, 2016
@magento-team magento-team merged commit d1299d0 into magento:develop Mar 3, 2016
magento-team pushed a commit that referenced this pull request Mar 3, 2016
- Revised comments added by contributor.
magento-team pushed a commit that referenced this pull request Mar 3, 2016
@okorshenko
Copy link
Contributor

@nagno Your Pull Request merged to develop branch. Thank you for contribution!

magento-engcom-team pushed a commit that referenced this pull request Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants