Skip to content

Fixed #19258 Incorrect orders updated #20349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shikhamis11
Copy link
Member

@shikhamis11 shikhamis11 commented Jan 16, 2019

Fixed #19258 Incorrect orders updated

Preconditions (*)

  1. Magento 2.2.5
  2. Php 7.0

Steps to reproduce (*)

  1. Open order grid in two tabs.
  2. Apply filter of order status in both tabs. Both tabs should show same orders. (ex. pending)
  3. Select first order in first tab and change the status of order(ex. change to hold).
  4. Without refresh select same order in second tab and update status(ex. change to cancel)

Expected result (*)

  1. It should show exception message saying "Cant update order" or "No order to update" with id
    image

Actual result (*)

  1. All orders were updated to cancel status except the one updated in first tab.
    image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixed magento#19258 Incorrect orders updated
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@shikhamis11
Copy link
Member Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your new Magento instance.
Admin access: https://pr-20349.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@shikhamis11
Copy link
Member Author

I checked It's working over the test instance

@aleron75 aleron75 self-assigned this Jan 17, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 17, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3891 has been created to process this Pull Request

@aleron75
Copy link
Contributor

Hello @shikhamis11, thanks for your contribution.

Once merged, don't forget you can easily port this PR (if needed) to other branches with the Porting Tool, read more here.

@ghost
Copy link

ghost commented Jan 26, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants