Skip to content

Tier price on configurable product sorting sometimes wrong #20407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vshatylo
Copy link
Contributor

@vshatylo vshatylo commented Jan 18, 2019

Description (*)

Tier prices on configurable product have sorting that differ then in back office.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. edit option assigned to configurable product
  2. add tier prices to option:
  • all websites ; all groups ; qty 4; price 1
  • all websites ; all groups ; qty 3; price 2
  • all websites ; all groups ; qty 2; price 3
  1. save option
  2. visit configurable product detail page
    Tier Prices on frontend should be in displayed in same order as in back office

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vshatylo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 18, 2019
@sivaschenko sivaschenko self-assigned this Jan 18, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3913 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vshatylo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Jan 26, 2019

Hi @vshatylo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @vshatylo. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants