Sorting by Websites not working in product grid in backoffice #20511 by XxXgeoXxX · Pull Request #20512 · magento/magento2

XxXgeoXxX · 2019-01-23T11:40:29Z

issue #20511

Description (*)

Preconditions (*)

Magento Version : CE 2.2X
Magento Version : CE 2.3.X

Steps to reproduce (*)

Navigate to admin catalog product grid
Using "Columns" selection add Websites'' column in the grid

Expected result (*)

Sort by 'Websites' should be working fine.

Actual result (*)

Sort by 'websites' product attribute not working.

Manual testing scenarios (*)

Navigate to admin catalog product grid
Using "Columns" selection add Websites'' column in the grid

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…#20511

magento-engcom-team · 2019-01-23T11:40:32Z

Hi @XxXgeoXxX. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

…velop#20511

…#20511

vpodorozh · 2019-02-13T07:19:45Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-02-13T07:19:47Z

Hi @vpodorozh. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-02-13T07:20:43Z

Hi @vpodorozh, here is your new Magento instance.
Admin access: https://pr-20512.instances.magento-community.engineering/admin
Login: admin Password: 123123q

vpodorozh

@XxXgeoXxX - thank you for your contribution.
Could you please take a look at my "change request"?
Also, it would be awesome if you would add the MFTF test for product grid sorting by website.
Thank you!

app/code/Magento/Catalog/Ui/Component/Listing/Columns/Websites.php

…#20511

vpodorozh · 2019-02-14T05:48:28Z

@XxXgeoXxX - what about MFTF test?

vpodorozh · 2019-02-19T15:58:41Z

@XxXgeoXxX - what about MFTF test?

Please add it, thx!

XxXgeoXxX · 2019-02-20T09:54:21Z

Hi @vpodorozh
Mftf test was created. Could you review?

…#20511

magento-engcom-team · 2019-03-01T07:23:38Z

Hi @vpodorozh, thank you for the review.
ENGCOM-4405 has been created to process this Pull Request

okolesnyk · 2019-03-01T17:03:02Z

app/code/Magento/Catalog/Test/Mftf/Test/AdminSortingByWebsitesTest.xml

+            <!--Create new website -->
+            <actionGroup ref="AdminCreateWebsiteActionGroup" stepKey="createAdditionalWebsite">
+                <argument name="newWebsiteName" value="Second Website"/>
+                <argument name="websiteCode" value="second_website"/>


I would recommend to use data entity customWebsite.
It will create unique WebSite Name and WebSite code.
Arguments will look like this

<argument name="newWebsiteName" value="{{customWebsite.name}}"/> <argument name="websiteCode" value="{{customWebsite.code}}"/>

okolesnyk · 2019-03-01T17:04:34Z

app/code/Magento/Catalog/Test/Mftf/Test/AdminSortingByWebsitesTest.xml

+        </before>
+        <after>
+            <actionGroup ref="AdminDeleteWebsiteActionGroup" stepKey="deleteTestWebsite">
+                <argument name="websiteName" value="Second Website"/>


Once you will use customWebsite entity, you should also specify it here: <argument name="websiteName" value="{{customWebsite.name}}"/>
And also you should specify {{customWebsite.name}} in all actions you specified 'Second Website'

…#20511

XxXgeoXxX · 2019-03-01T22:16:22Z

Hi @okolesnyk
Test was improved according recomandation.

VasylShvorak · 2019-03-06T11:02:47Z

✔️ QA passed

okolesnyk · 2019-03-08T10:33:01Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-03-08T10:33:04Z

Hi @okolesnyk. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-03-08T10:33:47Z

Hi @okolesnyk, here is your Magento instance.
Admin access: https://i-20512-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

okolesnyk · 2019-03-08T14:57:25Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-03-08T14:57:27Z

Hi @okolesnyk. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-03-08T14:58:10Z

Hi @okolesnyk, here is your Magento instance.
Admin access: https://i-20512-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

…20511

ghost · 2019-03-16T15:01:49Z

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…ffice #20511 #20512

Sorting by Websites not working in product grid in backoffice magento…

0dfe0f0

…#20511

magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 23, 2019

XxXgeoXxX mentioned this pull request Jan 23, 2019

[Backport]Sorting by Websites not working in product grid in backoffice #20514

Closed

4 tasks

vpodorozh self-requested a review February 12, 2019 07:05

XxXgeoXxX added 2 commits February 13, 2019 07:55

Merge branch '2.3-develop' of github.com:magento/magento2 into 2.3-de…

e61b399

…velop#20511

Sorting by Websites not working in product grid in backoffice magento…

fa49579

…#20511

vpodorozh suggested changes Feb 13, 2019

View reviewed changes

app/code/Magento/Catalog/Ui/Component/Listing/Columns/Websites.php Outdated Show resolved Hide resolved

app/code/Magento/Catalog/Ui/Component/Listing/Columns/Websites.php Outdated Show resolved Hide resolved

Sorting by Websites not working in product grid in backoffice magento…

8170bd7

…#20511

Sorting by Websites not working in product grid in backoffice

f4d1442

XxXgeoXxX added 2 commits February 20, 2019 13:01

Sorting by Websites not working in product grid in backoffice

93da772

Sorting by Websites not working in product grid in backoffice magento…

5362c5a

…#20511

ghost assigned vpodorozh Mar 1, 2019

vpodorozh approved these changes Mar 1, 2019

View reviewed changes

ghost added the Progress: ready for testing label Mar 1, 2019

okolesnyk suggested changes Mar 1, 2019

View reviewed changes

Sorting by Websites not working in product grid in backoffice magento…

f57e5e8

…#20511

okolesnyk added the Award: MFTF test coverage label Mar 1, 2019

okolesnyk approved these changes Mar 1, 2019

View reviewed changes

VasylShvorak self-assigned this Mar 6, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 6, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Mar 6, 2019

nmalevanec self-assigned this Mar 12, 2019

Merge remote-tracking branch 'mainline/2.3-develop' into 2.3-develop#…

a6f266d

…20511

sivaschenko mentioned this pull request Mar 12, 2019

Fixed #6208 Can't sort by "Websites" in the Products > Catalog list #20937

Closed

4 tasks

nmalevanec force-pushed the 2.3-develop#20511 branch from 92a7749 to a6f266d Compare March 13, 2019 16:14

nmalevanec added 2 commits March 13, 2019 18:15

Fix static and functional tests.

a32d27b

Merge remote-tracking branch 'mainline/2.3-develop' into 2.3-develop#…

c76d248

…20511

ghost added Progress: accept and removed Progress: extended testing labels Mar 14, 2019

magento-engcom-team added Award: bug fix and removed Award: MFTF test coverage labels Mar 14, 2019

magento-engcom-team mentioned this pull request Mar 16, 2019

Sorting by 'Websites' not working in product grid in backoffice #20511

Closed

magento-engcom-team merged commit c76d248 into magento:2.3-develop Mar 16, 2019

magento-engcom-team pushed a commit that referenced this pull request Mar 16, 2019

ENGCOM-4405: Sorting by Websites not working in product grid in backo…

5376a81

…ffice #20511 #20512

magento-engcom-team added this to the Release: 2.3.2 milestone Mar 16, 2019

Conversation

XxXgeoXxX commented Jan 23, 2019

Description (*)

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

magento-engcom-team commented Jan 23, 2019

Uh oh!

vpodorozh commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

magento-engcom-team commented Feb 13, 2019

Uh oh!

vpodorozh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vpodorozh commented Feb 14, 2019

Uh oh!

vpodorozh commented Feb 19, 2019

Uh oh!

XxXgeoXxX commented Feb 20, 2019

Uh oh!

magento-engcom-team commented Mar 1, 2019

Uh oh!

okolesnyk Mar 1, 2019

Choose a reason for hiding this comment

Uh oh!

XxXgeoXxX Mar 1, 2019

Choose a reason for hiding this comment

Uh oh!

okolesnyk Mar 1, 2019

Choose a reason for hiding this comment

Uh oh!

XxXgeoXxX Mar 1, 2019

Choose a reason for hiding this comment

Uh oh!

XxXgeoXxX commented Mar 1, 2019

Uh oh!

VasylShvorak commented Mar 6, 2019

Uh oh!

okolesnyk commented Mar 8, 2019

Uh oh!

magento-engcom-team commented Mar 8, 2019

Uh oh!

magento-engcom-team commented Mar 8, 2019

Uh oh!

okolesnyk commented Mar 8, 2019

Uh oh!

magento-engcom-team commented Mar 8, 2019

Uh oh!

magento-engcom-team commented Mar 8, 2019

Uh oh!

ghost commented Mar 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants