Skip to content

Solve custom option dropdown issue #20990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Solve custom option dropdown issue #20990

merged 1 commit into from
Feb 12, 2019

Conversation

dharmendra-wagento
Copy link
Contributor

Description (*)

Admin Customizable Options Dropdown sort_order issue

Fixed Issues (if relevant)

  1. Admin Customizable Options Dropdown sort_order issue #20989: Admin Customizable Options Dropdown sort_order issue

Manual testing scenarios (*)

  1. Go to Catalog > Products
  2. Edit/New Product
  3. Expand Customizable Options and click on Add Option
  4. Choose Drop Dowm as New Option Type
  5. Add 1 or 2 Values
    6 . Now , Change Option type from drop down to field or area
  6. Now again choose Drop Dowm as Option Type
  7. Add 1 or 2 Values

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dharmendra-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 5, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Feb 5, 2019
@dharmendra-wagento
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @dharmendra-wagento. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dharmendra-wagento, here is your Magento instance.
Admin access: https://i-20990-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@dmytro-ch dmytro-ch self-requested a review February 5, 2019 15:03
@dmytro-ch dmytro-ch self-assigned this Feb 5, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-20990.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4150 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@dharmendra-wagento thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @dharmendra-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: Catalog Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants