-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed Cache Management mass-action checkbox alignment #21257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @dmytro-ch, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mage2pratik,
thank you for your contribution!
Could you please also revert the changes made for functional test app/code/Magento/Sales/Test/Mftf/Section/OrdersGridSection.xml
in #21022.
Hi @dmytro-ch, thank you for the review. |
Hi @mage2pratik , thank you for the pull request! This PR is basically a revert of the fix for #21021 . Will you be able to provide a correct fix for that issue in this PR as well? |
Hi @sivaschenko, Thank you! |
Hi @dmytro-ch I completely agree with your concern, I simply was wondering if we could not just revert the fix, but correct it. |
@magento-engcom-team give me 2.3-develop instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @dmytro-ch, here is your Magento instance. |
@sivaschenko, please note, the alignment issue has already been fixed in #20237. Thank you! |
@mage2pratik @dmytro-ch looks like both #21255 and #21021 are fixed on latest 2.3-develop, can you please confirm that and close this PR if necessary |
Yes, the bug with backend Cache Management mass action checkbox alignment has been has been also fixed in #20237. |
Hi @mage2pratik, thank you for your contribution! |
Description (*)
Fixed Cache Management mass-action checkbox alignment
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)