Skip to content

MC-13537: added default Country Id to checkout Config. #21280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AleksLi
Copy link
Contributor

@AleksLi AleksLi commented Feb 15, 2019

Description (*)

The reason of that bug is: the DefaultCountryId sets from the config path tax/defaults/country and not from general/country/default of Magento 2 configuration. That's why when you're go to the checkout and that's your first time, session wasn't saved in browser, table rates are wrong.

Fixed Issues (if relevant)

  1. magento/magento2#<13537>: Magento 2.2.0 One page checkout initial postage calculation ignores "default country" using table rate shipping.

Manual testing scenarios (*)

  1. Set Default country to "United Kingdom".
  2. Setup table rate shipping.
  3. Add item to cart.
  4. Proceed to one page checkout.
  5. Default country is set automatically to "United Kingdom" as expected.
  6. The initial shipping price displayed is that of the USA but should be the UK.
  7. Deselect then reselect "United Kingdom" the shipping price refreshes correctly.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 15, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @AleksLi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think providing new config to tax configs like defaultTaxCountryId without any future usage is not proper fix which we need.

@sidolov
Copy link
Contributor

sidolov commented Apr 19, 2019

@AleksLi , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2019

Hi @AleksLi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants