Fix #21648 Checkout Agreements checkbox missing asterisk

[Karlasa]

Description (*)

Fixed Issues (if relevant)

1. Checkout Agreements checkbox missing asterisk #21648 : missing asterisk in checkout Agreements

Manual testing scenarios (*)

Create Terms and Conditions agreement
Enable it with "manual" setting so checkbox would be shown
Go to checkout
Expected result (*)
Agreement checkbox label should have red asterisk as it's required to check it

Actual result (*)
Asterisk is missing and after pressing place order gives message that field is required

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[Karlasa]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21649.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[Karlasa]

double checked looks correct 👍

[rogyar]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21649.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4475 has been created to process this Pull Request

[soleksii]

Hi @Karlasa! I've checked PR and found a problem.

Manual testing scenario:

1. Login to Admin;
2. Go to Stores -> Terms and Conditions, press button "Add New Condition";
3. Fill all required fields, select "manual" from "Applied" drop-down menu and Save it;
4. Enable "Terms and Conditions" ( Go to Stores->Configuration->Sales->Checkout->Checkout Options)
5. Change theme to Blank;
6. Go to Storefront;
7. Add any product to Cart and click "Proceed to Checkout";
8. Fill all required fields and click "Next" button;
   ❌ In "Review & Payments" page checkbox and asterisk has incorrect position;
   

[Karlasa]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21649.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[Karlasa]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-21649.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[Karlasa]

@stoleksiy Thanks for finding that bug 👍
added required changes.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-4475 has been created to process this Pull Request

[soleksii]

✔️ QA Passed

Result (Luma):

Result (Blank):

[ghost]

Hi @Karlasa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.