It is not possible to add MS tile image meta via default_head_blocks.xml #21798

vasilii-b · 2019-03-16T14:58:39Z

Description (*)

Fixes issue #5023, where you're not able to add a MS tile image with image url from theme.

<meta name="msapplication-TileImage" content="images/favicons/default/mstile-144x144.png">

Fixed Issues (if relevant)

It is not possible to add MS tile image meta via default_head_blocks.xml #5023

Manual testing scenarios (*)

Please check the issue description.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…lt_head_blocks.xml

magento-engcom-team · 2019-03-16T14:58:42Z

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

lib/internal/Magento/Framework/View/Page/Config.php

larsroettig · 2019-03-16T16:19:50Z

lib/internal/Magento/Framework/View/Page/Config.php

+    public function getAdditionalMetaAssets()
+    {
+        return $this->additionalMetaAssets;
+    }


Empty Line is missing there .

lib/internal/Magento/Framework/View/Page/Config.php

larsroettig · 2019-03-16T16:21:41Z

lib/internal/Magento/Framework/View/Test/Unit/Page/ConfigTest.php

@@ -369,6 +369,20 @@ public function testAddRss()
        $this->assertInstanceOf(\Magento\Framework\View\Page\Config::class, $this->model->addRss($title, $href));
    }

+    public function testGetMetaAssetUrlWithUrlInContent()


Function comment is missing there

larsroettig · 2019-03-16T16:21:47Z

lib/internal/Magento/Framework/View/Test/Unit/Page/ConfigTest.php

+        $this->assetRepo->expects($this->never())->method('getUrl');
+        $this->assertEquals('http://test.com/image.png', $this->model->getMetaAssetUrl('http://test.com/image.png'));
+    }
+


Function comment is missing there

…lt_head_blocks.xml # Added codestyle fixes

larsroettig · 2019-03-19T12:48:21Z

lib/internal/Magento/Framework/View/Page/Config.php

+     */
+    public function getMetaAssetUrl($content)
+    {
+        $parsed = parse_url($content);


Hi can you add the second parameter, please

Hi @larsroettig, I've seen you marked as resolved the previous comment and thought its not needed.
Will add it. Thank you!

…lt_head_blocks.xml # Changed the way how asset url is checked for URL scheme to a more consistent approach

magento-engcom-team · 2019-03-20T20:53:39Z

Hi @larsroettig, thank you for the review.
ENGCOM-4544 has been created to process this Pull Request

VasylShvorak · 2019-03-22T12:04:58Z

✔️ QA passed

vasilii-b · 2019-07-10T12:25:47Z

Hi @sivaschenko, @larsroettig,
Could you guys please check if added changes are good from "Backward compatible" perspective or any other issues are found?
Thank you!

…ia default_head_blocks.xml # Introduced a new class that provides URL for MS tile image during page config metadata generation

magento-engcom-team · 2019-08-15T16:17:46Z

Hi @sidolov, thank you for the review.
ENGCOM-5635 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Delta · 2019-08-20T14:00:26Z

✔️ QA passed

engcom-Foxtrot · 2019-08-21T08:03:37Z

@magento run all tests

…_head_blocks.xml #21798

m2-assistant · 2019-08-26T17:56:42Z

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#5023 - It is not possible to add MS tile image meta via defau…

a2551af

…lt_head_blocks.xml

vasilii-b added the Event: lvivcd19 label Mar 16, 2019

magento-engcom-team added Component: View Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 16, 2019

larsroettig requested changes Mar 16, 2019

View reviewed changes

lib/internal/Magento/Framework/View/Page/Config.php Outdated Show resolved Hide resolved

ghost assigned larsroettig Mar 16, 2019

ghost added the Progress: needs update label Mar 16, 2019

larsroettig requested changes Mar 16, 2019

View reviewed changes

magento#5023 - It is not possible to add MS tile image meta via defau…

3d193bf

…lt_head_blocks.xml # Added codestyle fixes

vasilii-b requested a review from larsroettig March 17, 2019 16:53

larsroettig requested changes Mar 19, 2019

View reviewed changes

magento#5023 - It is not possible to add MS tile image meta via defau…

2faa1ec

…lt_head_blocks.xml # Changed the way how asset url is checked for URL scheme to a more consistent approach

vasilii-b requested a review from larsroettig March 20, 2019 07:40

larsroettig approved these changes Mar 20, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Mar 20, 2019

VasylShvorak self-assigned this Mar 22, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Mar 22, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Mar 22, 2019

p-bystritsky self-assigned this Mar 22, 2019

ENGCOM-4544: Semantic Version Checker fix.

56a368f

ghost added Progress: accept and removed Progress: extended testing labels Mar 25, 2019

ghost unassigned p-bystritsky and VasylShvorak Jul 10, 2019

magento/magento:5023 - It is not possible to add MS tile image meta v…

8892b0b

…ia default_head_blocks.xml # Introduced a new class that provides URL for MS tile image during page config metadata generation

vasilii-b force-pushed the 2.3-layout-head-ms-tile-image-meta-tag branch from 1c20130 to 8892b0b Compare July 10, 2019 12:29

sidolov approved these changes Aug 15, 2019

View reviewed changes

ghost assigned sidolov Aug 15, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 15, 2019

engcom-Delta self-assigned this Aug 20, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 20, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 20, 2019

engcom-Foxtrot self-assigned this Aug 21, 2019

magento#21798: Static test fix.

a917ee7

p-bystritsky force-pushed the 2.3-layout-head-ms-tile-image-meta-tag branch from ffd257c to a917ee7 Compare August 21, 2019 12:12

ghost added Progress: accept and removed Progress: extended testing labels Aug 22, 2019

magento-engcom-team added the Award: bug fix label Aug 22, 2019

magento-engcom-team mentioned this pull request Aug 26, 2019

It is not possible to add MS tile image meta via default_head_blocks.xml #5023

Closed

magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2019

ENGCOM-5635: It is not possible to add MS tile image meta via default…

db70870

…_head_blocks.xml #21798

magento-engcom-team merged commit a917ee7 into magento:2.3-develop Aug 26, 2019

magento-engcom-team added this to the Release: 2.3.4 milestone Aug 26, 2019

sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

It is not possible to add MS tile image meta via default_head_blocks.xml #21798

It is not possible to add MS tile image meta via default_head_blocks.xml #21798

Uh oh!

vasilii-b commented Mar 16, 2019

Uh oh!

magento-engcom-team commented Mar 16, 2019

Uh oh!

Uh oh!

larsroettig Mar 16, 2019

Uh oh!

Uh oh!

larsroettig Mar 16, 2019

Uh oh!

larsroettig Mar 16, 2019

Uh oh!

larsroettig Mar 19, 2019

Uh oh!

vasilii-b Mar 19, 2019

Uh oh!

magento-engcom-team commented Mar 20, 2019

Uh oh!

VasylShvorak commented Mar 22, 2019

Uh oh!

vasilii-b commented Jul 10, 2019

Uh oh!

magento-engcom-team commented Aug 15, 2019

Uh oh!

engcom-Delta commented Aug 20, 2019

Uh oh!

engcom-Foxtrot commented Aug 21, 2019

Uh oh!

m2-assistant bot commented Aug 26, 2019

Uh oh!

Uh oh!

It is not possible to add MS tile image meta via default_head_blocks.xml #21798

It is not possible to add MS tile image meta via default_head_blocks.xml #21798

Uh oh!

Conversation

vasilii-b commented Mar 16, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

magento-engcom-team commented Mar 16, 2019

Uh oh!

Uh oh!

larsroettig Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

larsroettig Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

larsroettig Mar 16, 2019

Choose a reason for hiding this comment

Uh oh!

larsroettig Mar 19, 2019

Choose a reason for hiding this comment

Uh oh!

vasilii-b Mar 19, 2019

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Mar 20, 2019

Uh oh!

VasylShvorak commented Mar 22, 2019

Uh oh!

vasilii-b commented Jul 10, 2019

Uh oh!

magento-engcom-team commented Aug 15, 2019

Uh oh!

engcom-Delta commented Aug 20, 2019

Uh oh!

engcom-Foxtrot commented Aug 21, 2019

Uh oh!

m2-assistant bot commented Aug 26, 2019

Uh oh!

Uh oh!