Skip to content

#21789 Fix gallery event observer #21906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Mar 23, 2019

Description (*)

This PR fix issue of opening gallery if moving mouse to image when clicking to another element of page

Original PR #21790

Fixed Issues (if relevant)

  1. [BUG] Product gallery opening by mistake #21789: [BUG] Product gallery opening by mistake

Manual testing scenarios (*)

  1. Open product page
  2. Click to product qty move cursor to product image and up mouse button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Mar 23, 2019

@Den4ik unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ghost
Copy link

ghost commented Mar 23, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants