Skip to content

Fixes issue - #21824. "save_parameters_in_session" set to true for admin user grid #22128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

jayankaghosh
Copy link
Contributor

@jayankaghosh jayankaghosh commented Apr 3, 2019

Description (*)

Fixes issue - #21824. "save_parameters_in_session" set to true for admin user grid through xml

Fixed Issues (if relevant)

  1. Filter in admin users grid in backend isn't being remembered #21824: Filter in admin users grid in backend isn't being remembered

Manual testing scenarios (*)

  1. Go to Admin >> System >> Permissions >> All Users
  2. Filter grid by "User Name", "First Name" or "Last Name"
  3. Click to any admin user
  4. Come back to the "All Users" grid.
  5. The applied filter should stay

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @jayankaghosh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@jayankaghosh
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @jayankaghosh. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @jayankaghosh, here is your new Magento instance.
Admin access: https://pr-22128.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned orlangur Apr 3, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4655 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Apr 9, 2019

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @jayankaghosh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 15, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 15, 2019
@jayankaghosh jayankaghosh deleted the issue-21824 branch April 22, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants