[Performance] Fix array merge in loop to speed up static content deploy

[ihor-sviziev]

Description (*)

This PR improving static content deploy speed.

For instance i tried to compile Magento/blank theme for 6 different locales (I have all these language packs installed).

php bin/magento setup:static-content:deploy -f --jobs=2 --area frontend en_US locale2 locale3 locale4 locale5 locale6 --theme Magento/blank

Before applying this patch: 109 seconds on my machine.
After applying this patch: 93 seconds on my machine.

If we'll execute for SCD for multiple theme - results should be bigger.

More info about array_merge in loop:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@ihor-sviziev if I remember correctly, we have a rule in recently released coding standard for array_merge in loop. Could you please check?

[orlangur]

@ihor-sviziev ok, that's here I saw it: magento/magento-coding-standard#72 (comment)

So, standard is just evolving without any connection with reality :)

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4723 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[sidolov]

An integration test is failing with provided changes: \Magento\Deploy\DeployTest
After the short investigation, we found that $path var can be the type of array and will break the check $this->map[$fileName].

[sidolov]

Hi @ihor-sviziev , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[orlangur]

@ihor-sviziev wazzup?)

[ihor-sviziev]

@ihor-sviziev wazzup?)

There is an issue that really hard to debug. I don't have free time for now.

[ihor-sviziev]

FYI I applied the same change (and fixed it) in the #30153, it already got merged.