Skip to content

[Backport] Previous scrolling to invalid form element is not being canceled on h… #22358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amol2jcommerce
Copy link
Contributor

Original Pull Request

#22117
…itting submit multiple times #21715

Description (*)

This issue was caused because of adding new jQuery animation every validation error of the QTY field without stopping the previous animation so I've added stopping the previous animation.

Fixed Issues (if relevant)

  1. Previous scrolling to invalid form element is not being canceled on hitting submit multiple times #21715: Previous scrolling to invalid form element is not being canceled on hitting submit multiple times

Manual testing scenarios (*)

  1. Go to a product page
  2. Enter an invalid value like -1
  3. Hit 'Add to cart' several times
  4. When you get scrolled to the qty input try scrolling away
  5. When scrolling is finished, the form will let you scroll away, no matter how many times you hit the add to cart button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sidolov Apr 24, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4820 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-4820 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 26, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 26, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants