Backport Magento 2.2 Set cache id prefix on installation #22439
Conversation
|
Hi @Ctucker9233. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @orlangur, thank you for the review. |
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA Passed |
ghost
added
Progress: extended testing
and removed
Progress: testing in progress
labels
| @@ -116,6 +122,60 @@ public function testCreateConfigWithRedisConfig() | |||
| $this->assertEquals($expectedConfigData, $configData->getData()); | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
@orlangur I think this line is causing the Travis CL build to fail. Correct me if I'm wrong but this preserves the authorship so I don't think it can simply be removed.
| @@ -36,6 +39,9 @@ protected function setUp() | |||
| $this->configOptionsList = new CacheConfigOptionsList($this->validatorMock); | |||
| } | |||
|
|
|||
| /** | |||
| * testGetOptions | |||
There was a problem hiding this comment.
@nmalevanec why need to add such useless annotations? Tests were ignored before, what caused such a bug?
There was a problem hiding this comment.
@orlangur, I've moved this comment from 2.3-develop. But, ok I'll remove it.
There was a problem hiding this comment.
@nmalevanec no need to remove, they must be not needed in 2.3-develop as well.
nmalevanec
force-pushed
the
Ctucker9233-issue-18641
branch
from
45b6a3d to
9d26084
Compare
|
Hi @Ctucker9233, thank you for your contribution! |
Original Pull Request #18641
Description (*)
The undocumented id_prefix option for the cache frontend is used to prefix cache keys. If it is not set, Magento uses the first 12 bits of the md5 hash of the absolute path to Magentos app/etc directory. But if this is not exactly the same on all web servers, cache invalidation does not work.
Source: https://github.com/magento/magento2/blob/2.3-develop/lib/internal/Magento/Framework/App/Cache/Frontend/Factory.php#L121-L130
To prevent this issue, the value shall be set on installation, so that the fall back on the fly does not happen anymore. Optionally, the value can be specified explicitly.
Fixed Issues (if relevant)
#15828: Multisite installation, default website slow
Manual testing scenarios (*)
Contribution checklist (*)