Fixed issue #21650

[geet07]

Description (*)

Saving product with options with thousands separator in price fails.

Fixed Issues (if relevant)

1. magento/magento2#<21650>: Saving product with options with thousands separator in price fails

Manual testing scenarios (*)

1. Add Product with custom options (Price: 1000).
2. Once Product saved, Again edit the same product with custom options now you can save all values sucessfully.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @geet07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[orlangur]

@geet07 we cannot simply remove validation. Corrected validator must be used instead.

[geet07]

@geet07 we cannot simply remove validation. Corrected validator must be used instead.

Hi @orlangur,

Thank you for message.

As per your comment I have added validation same a catalog main price. So now you can check this and let me know if there is another changes reqiured.

[orlangur]

Thanks @geet07! Did you check implementation why validate-number is not working?

[geet07]

Thanks @geet07! Did you check implementation why validate-number is not working ?

Yes I have checked, When we change the locale for admin user then there will be change in price format, So due to this "thousands separator" position also change & that 'validation-number' validation doesn't work too. I have also checked with other price field that 'validation-number' validation not use in the current system.

[geet07]

Hi @orlangur,

Is there any another changes required?

[geet07]

Hi @orlangur,

Can You please help me to close this issue.

[m2-assistant]

Hi @geet07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.