-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed issue #21650 #22699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #21650 #22699
Conversation
Hi @geet07. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geet07 we cannot simply remove validation. Corrected validator must be used instead.
Thanks @geet07! Did you check implementation why |
Yes I have checked, When we change the locale for admin user then there will be change in price format, So due to this "thousands separator" position also change & that 'validation-number' validation doesn't work too. I have also checked with other price field that 'validation-number' validation not use in the current system. |
Hi @orlangur, Is there any another changes required? |
Hi @orlangur, Can You please help me to close this issue. |
Hi @geet07, thank you for your contribution! |
Description (*)
Saving product with options with thousands separator in price fails.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)