Skip to content

[Backport] Fixed #22506: Search suggestion panel overlapping on advance reporting button #23151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

krishprakash
Copy link

@krishprakash krishprakash commented Jun 6, 2019

Original Pull Request

#22520

Search suggestion panel overlapping on advance reporting button Fixed.

Description (*)

In this PR is have fixed Search suggestion panel overlapping on advance reporting button.

Fixed Issues (if relevant)

  1. Search suggestion panel overlapping on advance reporting button #22506
  2. ...

Manual testing scenarios (*)

  1. Log into the admin panel
  2. Click on search icon form the dashboard
  3. Enter any Search keyword (Email Id) or Long text.
  4. Search result pop-up is now not overlapping on advanced reporting button.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your new Magento instance.
Admin access: https://pr-23151.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krishprakash
Copy link
Author

Issue fixed in given instance.

@ronak2ram ronak2ram self-requested a review June 6, 2019 06:32
@ronak2ram ronak2ram self-assigned this Jun 6, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5214 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 6, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants