Load product in default store before duplicating #23209

JeroenVanLeusden · 2019-06-11T14:32:04Z

Description (*)

Duplicating a product will use the current scope data as default values instead of copying it from the original product.

Fixed Issues (if relevant)

Duplicate product #15656: Duplicate product

Manual testing scenarios (*)

Create product with different values in different StoreViews (e.g StoreView UK, NL, DE, ...)
Open product and select one StoreView (e.g. UK - not "All StoreViews"!)
Click on "Save product & duplicate"

Questions or comments

Not really happy with reloading the product while we have it already as method parameter. Maybe deprecate the copy() method and create a copyBySku() method?

Will update tests if implementation is approved by Magento.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-06-11T14:32:08Z

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

dmytro-ch

Hi @JeroenVanLeusden!

Not really happy with reloading the product while we have it already as method parameter. Maybe deprecate the copy() method and create a copyBySku() method?

I also agree, it would be better to pass the already correct product data as copy method parameter.
So we may try to load the product via repository in case the current_store_id value of the product is not equal to Store::DEFAULT_STORE_ID, instead of using the Product Builder in the following controller actions:

\Magento\Catalog\Controller\Adminhtml\Product\Duplicate::execute
\Magento\Catalog\Controller\Adminhtml\Product\Save::execute

The only problem, in my opinion, is that the product entity after loading does not contain all the necessary data. I guess, the bunch of data entries still need to be populated from request.

Thank you!

JeroenVanLeusden · 2019-06-13T13:48:54Z

Hi @dmytro-ch,

I can refactor the \Magento\Catalog\Controller\Adminhtml\Product\Save::execute te be:

if ($redirectBack === 'duplicate') {
    if ($product->getStoreId() === \Magento\Store\Model\Store::DEFAULT_STORE_ID) {
        $product->unsetData('quantity_and_stock_status');
        $productToDuplicate = $product;
    } else {
        $productToDuplicate = $this->productRepository->get(
            $product->getSku(),
            false,
            \Magento\Store\Model\Store::DEFAULT_STORE_ID,
            true
        );
    }

    $newProduct = $this->productCopier->copy($productToDuplicate);
    $this->messageManager->addSuccessMessage(__('You duplicated the product.'));
}

Although i'm not sure what you mean with:

in my opinion, is that the product entity after loading does not contain all the necessary data. I guess, the bunch of data entries still need to be populated from request.

The product is already saved so all the data we need should be there already when fetched using the repository?

Also, I've found no reference to \Magento\Catalog\Controller\Adminhtml\Product\Duplicate::execute. Can we deprecate this class?

dmytro-ch · 2019-06-17T14:30:40Z

@JeroenVanLeusden,
thank you for the update.

The new solution looks correct to me.

Although i'm not sure what you mean with:

in my opinion, is that the product entity after loading does not contain all the necessary data. I guess, the bunch of data entries still need to be populated from request.

The product is already saved so all the data we need should be there already when fetched using the repository?

I mean if you compare the results of $product->getData() and $productToDuplicate->getData() according to your code snippet, you may get the different number of values in resulting array. We just need to make sure the duplicated product does not lose any data.

Also, I've found no reference to \Magento\Catalog\Controller\Adminhtml\Product\Duplicate::execute.
Can we deprecate this class?

Sure

JeroenVanLeusden · 2019-06-27T08:13:05Z

Hi @dmytro-ch,

I've updated the PR, still using the repository to load the product because it duplicates just fine. Are there some additional tests I can do to make sure it's all good?

magento-engcom-team · 2019-08-23T15:19:41Z

Hi @sidolov, thank you for the review.
ENGCOM-5689 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Delta · 2019-08-28T07:09:19Z

Hi @JeroenVanLeusden during testing PR changes I found issue with product duplicate when different URL Key is set for each store view.
Manual testing scenario:

Create more than one store view:
Create product
Edit product for each store view and save:
- Default Store View:
- - Product Name=simple1 default
- - URL Key=simple1-def
- Second View:
- - Product Name=simple1 second
- - URL Key=simple1-second
- Third View:
- - Product Name=simple1 third
- - URL Key=simple1-third
- Notice: Create Permanent Redirect for old URL is checked on each store view when URL key is edited
Open product and select Second View
Click on "Save product & duplicate"

Result:
❌ Product Name value is set to All Store Views(e.g., "simple1") value for each store view

✔️ URL keys is generated correctly using store view value for it

Could you take a look?

ihor-sviziev

Hi @JeroenVanLeusden,

This PR is really closely related to #24505 and looks like changes from this PR could fix issue that described @engcom-Delta.
Could you collaborate with @webkul-paul to fix both these issues?

ihor-sviziev · 2019-09-11T05:57:37Z

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/Duplicate.php

@@ -6,6 +6,9 @@
 */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;

+/**
+ * @deprecated


Please add description why it became deprecated and add @see tag with example what we should use instead

ihor-sviziev · 2019-09-11T05:57:42Z

app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php

@@ -242,6 +242,7 @@ public function getProductSetId()

    /**
     * @return string
+     * @deprecated


Please add description why it became deprecated and add @see tag with example what we should use instead

ihor-sviziev · 2019-09-11T05:57:45Z

app/code/Magento/Catalog/Controller/Adminhtml/Product/Duplicate.php

@@ -9,6 +9,9 @@
 use Magento\Backend\App\Action;
 use Magento\Catalog\Controller\Adminhtml\Product;

+/**
+ * @deprecated


Please add description why it became deprecated and add @see tag with example what we should use instead

ihor-sviziev · 2019-09-11T05:58:11Z

app/code/Magento/Downloadable/Controller/Adminhtml/Downloadable/Product/Edit/Duplicate.php

@@ -6,6 +6,9 @@
 */
 namespace Magento\Downloadable\Controller\Adminhtml\Downloadable\Product\Edit;

+/**
+ * @deprecated


Please add description why it became deprecated and add @see tag with example what we should use instead

sidolov · 2019-09-16T15:35:25Z

@JeroenVanLeusden , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

m2-assistant · 2019-09-16T15:35:26Z

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: H&O partners-contribution Pull Request is created by Magento Partner labels Jun 11, 2019

dmytro-ch self-requested a review June 12, 2019 09:11

dmytro-ch self-assigned this Jun 12, 2019

JeroenVanLeusden force-pushed the JeroenVanLeusden-patch-1 branch from 4c05b3b to 3d15811 Compare June 12, 2019 09:51

dmytro-ch requested changes Jun 12, 2019

View reviewed changes

ghost added the Progress: needs update label Jun 12, 2019

Load product in default store before duplicating

50bd097

JeroenVanLeusden force-pushed the JeroenVanLeusden-patch-1 branch from 1e503ea to 50bd097 Compare June 24, 2019 13:52

sidolov approved these changes Aug 23, 2019

View reviewed changes

ghost assigned sidolov Aug 23, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 23, 2019

magento-engcom-team added Component: Bundle Component: Downloadable labels Aug 23, 2019

engcom-Delta self-assigned this Aug 27, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 27, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Aug 28, 2019

ihor-sviziev requested changes Sep 11, 2019

View reviewed changes

ghost assigned ihor-sviziev Sep 11, 2019

ihor-sviziev mentioned this pull request Sep 11, 2019

fixed issue #24438 - Duplicate product issues with different values for stores #24505

Closed

4 tasks

sidolov closed this Sep 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Load product in default store before duplicating #23209

Load product in default store before duplicating #23209

Uh oh!

JeroenVanLeusden commented Jun 11, 2019

Uh oh!

m2-assistant bot commented Jun 11, 2019

Uh oh!

dmytro-ch left a comment

Uh oh!

JeroenVanLeusden commented Jun 13, 2019

Uh oh!

dmytro-ch commented Jun 17, 2019

Uh oh!

JeroenVanLeusden commented Jun 27, 2019

Uh oh!

magento-engcom-team commented Aug 23, 2019

Uh oh!

engcom-Delta commented Aug 28, 2019

Uh oh!

ihor-sviziev left a comment •

edited

Loading

Uh oh!

ihor-sviziev Sep 11, 2019

Uh oh!

ihor-sviziev Sep 11, 2019

Uh oh!

ihor-sviziev Sep 11, 2019

Uh oh!

ihor-sviziev Sep 11, 2019

Uh oh!

sidolov commented Sep 16, 2019

Uh oh!

m2-assistant bot commented Sep 16, 2019

Uh oh!

Uh oh!

Load product in default store before duplicating #23209

Load product in default store before duplicating #23209

Uh oh!

Conversation

JeroenVanLeusden commented Jun 11, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jun 11, 2019

Uh oh!

dmytro-ch left a comment

Choose a reason for hiding this comment

Uh oh!

JeroenVanLeusden commented Jun 13, 2019

Uh oh!

dmytro-ch commented Jun 17, 2019

Uh oh!

JeroenVanLeusden commented Jun 27, 2019

Uh oh!

magento-engcom-team commented Aug 23, 2019

Uh oh!

engcom-Delta commented Aug 28, 2019

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

sidolov commented Sep 16, 2019

Uh oh!

m2-assistant bot commented Sep 16, 2019

Uh oh!

Uh oh!

ihor-sviziev left a comment •

edited

Loading