Fix cms block save for specified store view, when another block with same ID is saved for 'All Store Views'

[vovayatsyuk]

Description

Since Magento 2.3.1 I'm not able to save CMS block when another block with the same ID is saved for 'All store views'.

Manual testing scenarios

1. Create a CMS block test for 'All Store Views'
2. Try to create another one test for specific store view only
3. An error will be shown: "A block identifier with the same properties already exists in the selected store."

Questions or comments

This PR is just a git revert of the following commit: 1f743bd

If someone knows what was this commit about I'll be glad to fix it properly.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @vovayatsyuk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5780 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[engcom-Foxtrot]

@magento run all tests

[Munktells]

Can someone please clarify the status of this issue, is it going to be fixed, or is it closed? We are using the same CMS Block identifiers, to be able to use child themes, and this stopped working after the last upgrade to 2.3.3.

@sidolov or @vovayatsyuk do you know or can tell?

[ihor-sviziev]

Hi @engcom-Foxtrot,
Could you explain why this PR was sent to "on hold" status? What's the current status?

[ihor-sviziev]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-23255-2-4-develop.instances.magento-community.engineering/admin_0477
Login: 87f49478 Password: cda821a74acb
Instance will be terminated in up to 3 hours.

[ihor-sviziev]

Hi @vovayatsyuk,

I just tried to reproduce this issue on 2.4-develop branch - I was able to create 2 cms blocks without any issues.

Looks like this issue was fixed in c8baed5 , so I'm closing your PR.

Thank yo for contribution!

[m2-assistant]

Hi @vovayatsyuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.