Skip to content

[Backport] Fix unexpected diff between builds in generated/metadata directory #23327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ihor-sviziev
Copy link
Contributor

Original Pull Request

#23325

Description (*)

Sort all path definitions before generating config and writing it to generated/metadata directory

This issue caused by using RecursiveDirectoryIterator object for generating list of all classes and all their arguments and it could return not sorted result. As result files between builds are different just because files were found in different sort order.

Fixed Issues (if relevant)

  1. [Reproducible Builds] Diff in generated/metadata between the builds #23324: [Reproducible Builds] Diff in generated/metadata between the builds

Manual testing scenarios (*)

  1. See [Reproducible Builds] Diff in generated/metadata between the builds #23324 for details

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2019

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Sort all path definitions before generating config
@ihor-sviziev ihor-sviziev force-pushed the fix-sorting-in-generated-metadata branch from bd00020 to 6d057c4 Compare June 19, 2019 15:20
@orlangur orlangur self-assigned this Jun 19, 2019
@orlangur
Copy link
Contributor

Hi @ihor-sviziev, my understanding is that 2.2-develop can live without this change. I'll review it for 2.3-develop this week.

@orlangur orlangur closed this Jul 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2019

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants