Skip to content

Added missing Save on Bulk operation when being published #24052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

duckchip
Copy link
Contributor

@duckchip duckchip commented Aug 7, 2019

Description

When we create a new Bulk with a list of operations, the bulk is saved but the operations are not. Which results in everlasting pending operations in the operations grid

image

Fixed Issues (if relevant)

  1. New bulk schedule doesn't create operations automatically #23958: New bulk schedule doesn't create operations automatically

Manual testing scenarios

  1. Create new bulk
  2. Notice that the operations are added to the magento_operations table.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 7, 2019

Hi @duckchip. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@duckchip duckchip force-pushed the ISSUE-23958-Bulk-Operations branch from e1b06bd to fb8286c Compare August 7, 2019 15:11
@duckchip duckchip closed this Aug 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 9, 2019

Hi @duckchip, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants