Skip to content

Update Magento_AdvancedPricingImportExport ReadMe #24146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Update Magento_AdvancedPricingImportExport ReadMe #24146

merged 1 commit into from
Aug 16, 2019

Conversation

diazwatson
Copy link
Contributor

Description (*)

Updates ReadMe for Magento_AdvancedPricingImportExport module.

Fixed Issues (if relevant)

    1. magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2019

Hi @diazwatson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

In case you'd like to rerun tests use the following comments:

  • @magento run all tests - run all tests
  • @magento run { check name } - run a single test job (check name example: Static Tests build)

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner labels Aug 15, 2019
@diazwatson
Copy link
Contributor Author

Some thoughts about this PR:

Following the instructions in the ReadMe template I have skipped must of the sections because there is not much to tell about about this module BUT... don't you guys think it would be useful to add these sections with the link to DevDocs.

Example:

Layouts

This module does not introduces, updates or interact with any layout.

For more information about layouts in Magento 2, see the Layout documentation.

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-5645 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Aug 16, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 16, 2019
@diazwatson diazwatson deleted the ReadMe_AdvancedPricingImportExport branch August 18, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: AdvancedPricingImportExport Partner: Space 48 Partner Space48 contribution partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants