Skip to content

magento/magento2#: Replace deprecated Magento\Customer\Model\Customer::isConfirmationRequired method #24334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

magento/magento2#: Replace deprecated Magento\Customer\Model\Customer::isConfirmationRequired method #24334

wants to merge 1 commit into from

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Aug 28, 2019 •
edited
Loading

Description (*)

During new customer registration Magento\Customer\Model\ResourceModel\Customer model uses deprecated Magento\Customer\Model\Customer::isConfirmationRequired in the _beforeSave() method.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

Preconditions

  1. Set Require Emails Confirmation option to Yes on back-end side

back-end

Steps to reproduce

  1. Create new customer

  2. You will get a confirmation link in the email

Expected result: customer should get a confirmation email

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@m2-assistant
Copy link

m2-assistant bot commented Aug 28, 2019

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Customer Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 28, 2019
@dmytro-ch dmytro-ch self-requested a review August 28, 2019 10:15
@dmytro-ch dmytro-ch self-assigned this Aug 28, 2019
@atwixfirster atwixfirster force-pushed the customer-replace-deprecated-isConfirmationRequired branch 2 times, most recently from 98729bf to 1d039e5 Compare August 28, 2019 15:05
dmytro-ch
dmytro-ch requested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster, could you please also update the unit test for the session model?

app/code/Magento/Customer/Model/Customer.php
@@ -805,7 +815,7 @@ public function isConfirmationRequired()
*/
public function getRandomConfirmationKey()
{
return md5(uniqid());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, keep as it is.
Just ignore this rule:

// phpcs:ignore Magento2.Security.InsecureFunction

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, @dmytro-ch!

implemented

Thank you!

@atwixfirster atwixfirster force-pushed the customer-replace-deprecated-isConfirmationRequired branch from 1d039e5 to 3d03cb4 Compare August 28, 2019 20:01
@magento-engcom-team
Copy link
Contributor

Hi @atwixfirster
Thank you for your contribution. This pull request has been combined (merged) with #24340 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

@m2-assistant
Copy link

m2-assistant bot commented Aug 29, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team mentioned this pull request Aug 29, 2019
Merged
4 tasks
@sidolov sidolov mentioned this pull request Aug 29, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch requested changes

Assignees

@dmytro-ch dmytro-ch

Labels
Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atwixfirster @magento-engcom-team @dmytro-ch