#24376 update save/load query building logic, check definition of columns us…

[pierzakp]

…ed in conditions and prepare their values properly

Description (*)

This PR is proposing changes which are casting condition types according to the column definition type during select/update, which will be improving performance especially on int type indexes, currently, in many cases, it is passed as a string, in result index is not used.

Fixed Issues (if relevant)

1. Poor performance on sales order update - string to integer #24376: Poor performance on sales order update - string to integer

Manual testing scenarios (*)

1. turn on query logging, or view in mysql queries being ran
2. update an order
3. look at query
4. entity_id will be int

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @pierzakp. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sidolov]

Unfortunately, we are not allowed to add new protected methods to the @api classes according to our Backward Compatible Development Guide

[sidolov]

@pierzakp , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @pierzakp, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.