magento/magento2#: Declarative Install Schema. Add OnUpdate operation for constraints

[atwixfirster]

Description (*)

Now we can add ON DELETE operation for constraints via db_schema.xml only.

Pull request adds the ability to add ON UPDATE operation for constraints.

Syntax:

onUpdate="<REFERENCE_OPTION>"

reference_option:
    RESTRICT | CASCADE | SET NULL | NO ACTION | SET DEFAULT

See Magento\Framework\DB\Adapter\AdapterInterface

Example of usage:

<constraint xsi:type="foreign" referenceId="SALES_ORDER_STATUS_STATE_STATUS_SALES_ORDER_STATUS_STATUS"
                    table="sales_order_status_state" column="status" referenceTable="sales_order_status"
                    referenceColumn="status" onUpdate="CASCADE" onDelete="CASCADE"/>

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Thank you!

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @buskamuza,
Could you review this PR?

As for me - looks good, but wanted to get your feedback was on update not added because of some potential issues?

Tests could be fixed once idea will be approved.

[ihor-sviziev]

This is actually backward incompatible change. As for me - it's good reason to add it. @buskamuza what do you think?

[ihor-sviziev]

@buskamuza any updates?

[ihor-sviziev]

Created issue in architecture repo magento/architecture#310, hope it will help speed up response

[akaplya]

@atwixfirster @ihor-sviziev @buskamuza This feature was removed on purpose. We would like to keep entities identifiers as immutable values. ON UPDATE action means that object identifier can be changed somehow. If you don't have any objectives to this, let's close this PR.

[ihor-sviziev]

Hi @atwixfirster,

I'm closing this PR as it's not an issue.

For more details see #24644 (comment)

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[atwixfirster]

Hi @atwixfirster,

I'm closing this PR as it's not an issue.

For more details see #24644 (comment)

Thank you, @ihor-sviziev !

That was a nice try from my side.

Thank you for explanation, @akaplya