Skip to content

Issue #15656: Duplicate product #24752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

deadlexus
Copy link
Contributor

  • Fixed an issue with incorrect duplicating of product attributes when they have different values on store view level;
  1. Duplicate product #15656: Duplicate product

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

- Fixed an issue with incorrect duplicating of product attributes when they have different values on store view level;
@deadlexus deadlexus requested a review from akaplya as a code owner September 27, 2019 11:59
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @deadlexus. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 27, 2019

CLA assistant check
All committers have signed the CLA.

- Fixed static and unit tests;
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 27, 2019
@VladimirZaets VladimirZaets self-assigned this Sep 27, 2019
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deadlexus please, take a look at failed integration test, looks like scenario is broken with provided fix

@ghost ghost assigned sidolov Sep 27, 2019
@VladimirZaets
Copy link
Contributor

@deadlexus , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @deadlexus, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants