Skip to content

Fix #20332 - address fields sort order fixes #24784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fix #20332 - address fields sort order fixes #24784

merged 1 commit into from
Feb 28, 2020

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Sep 30, 2019 •
edited
Loading

Description (*)

This is fix for #20332

Fixed Issues (if relevant)

  1. Shipping address form City, State/Province, Zip/Postal Code, Country not in right Order in checkout  #20332: Shipping address form City, State/Province, Zip/Postal Code, Country not in right Order in checkout

Manual testing scenarios (*)

  1. Go to any form that contains customer address fields
  2. Four fields order should be changed to: Country, State/Province, City, Zip/Postal Code

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 30, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Bartlomiejsz Bartlomiejsz added the WIP Work In Progress label Nov 22, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:19
lenaorobei
lenaorobei requested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address BC comment and pull latest changes from 2.4-develop branch.

app/code/Magento/Checkout/Block/Checkout/LayoutProcessor.php Outdated
->get(\Magento\Shipping\Model\Config::class);
$this->storeManager = $storeManager ?: \Magento\Framework\App\ObjectManager::getInstance()
->get(StoreManagerInterface::class);
$this->options = $options ?: ObjectManager::getInstance()->get(Options::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObjectManager is redundant here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenaorobei done

@ghost ghost assigned lenaorobei Feb 3, 2020
@lenaorobei
Copy link
Contributor

@Bartlomiejsz could you please merge latest changes and address review comment?
Appreciate that!

@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_20332_address_fields_sort_order_incorrect branch 2 times, most recently from 28a2491 to 026a048 Compare February 25, 2020 21:34
@Bartlomiejsz Bartlomiejsz force-pushed the feature/fix_20332_address_fields_sort_order_incorrect branch from 026a048 to 2d759c0 Compare February 26, 2020 08:19
@Bartlomiejsz Bartlomiejsz removed the WIP Work In Progress label Feb 26, 2020
@Bartlomiejsz
Copy link
Contributor Author

@lenaorobei done, ready for review

@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 26, 2020
@magento-engcom-team magento-engcom-team added Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Feb 26, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6990 has been created to process this Pull Request

@Bartlomiejsz Bartlomiejsz linked an issue Feb 26, 2020 that may be closed by this pull request
Shipping address form City, State/Province, Zip/Postal Code, Country not in right Order in checkout #20332
Closed
@engcom-Delta engcom-Delta self-assigned this Feb 27, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Charlie engcom-Charlie self-assigned this Feb 27, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Feb 28, 2020
Closed
@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 28, 2020
@slavvka
ENGCOM-6990: Fix #20332 - address fields sort order fixes #24784
cac7100
@magento-engcom-team magento-engcom-team merged commit 15d21d3 into magento:2.4-develop Feb 28, 2020
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_20332_address_fields_sort_order_incorrect branch September 19, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Checkout Component: Customer Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shipping address form City, State/Province, Zip/Postal Code, Country not in right Order in checkout
6 participants
@Bartlomiejsz @lenaorobei @magento-engcom-team @engcom-Delta @sidolov @engcom-Charlie