Skip to content

Issue #25032 fixed #25062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Issue #25032 fixed #25062

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2019 •
edited by rodrigowebjump
Loading

Description (*)

Display some error "We can't update your Wish List right now." at wish list

Fixed Issues (if relevant)

  1. Display some error "We can't update your Wish List right now." at wish list #25032: Display some error "We can't update your Wish List right now." at wish list

Manual testing scenarios (*)

Scenario 1

  1. Front end > Add product to wish list
  2. Go to my wish list
  3. Edit the product from wish list
  4. From detail page leave qty blank and click on Update wish list

Scenario 2

  1. Front end > Add product to wish list
  2. Go to my wish list
  3. Edit the product from wish list
  4. From detail page type a negative quantity and click on Update wish list

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ghost ghost requested a review from DrewML as a code owner October 15, 2019 05:16
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2019

Hi @vishesh-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost added the Partner: Webkul label Oct 15, 2019
@ihor-sviziev
Copy link
Contributor

Hi @sidolov or @sivaschenko ,
Could you assist @vishesh-webkul why Partner: Webkul wasn't added automatically?

@sidolov
Copy link
Contributor

sidolov commented Oct 15, 2019

Hi @ihor-sviziev , @vishesh-webkul the label wasn't added automatically because Webkul does not participate in the Partners Contribution Program.

@rodrigowebjump rodrigowebjump self-requested a review October 18, 2019 23:07
@rodrigowebjump rodrigowebjump self-assigned this Oct 18, 2019
@rodrigowebjump
Copy link
Member

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-25062.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rodrigowebjump
Copy link
Member

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-25062-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

rodrigowebjump
rodrigowebjump requested changes Oct 27, 2019
View reviewed changes
Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vishesh-webkul

Your change does not validate if the inputed information is correct.
Please review your change. Try to follow the add to cart validation before submitting.

Thanks

VladimirZaets
VladimirZaets reviewed Nov 11, 2019
View reviewed changes
app/code/Magento/Wishlist/view/frontend/web/js/add-to-wishlist.js
@@ -63,6 +63,15 @@ define([
isFileUploaded = false,
self = this;

$('[data-action="add-to-wishlist"]').on('click', function () {
var validator = $('#product_addtocart_form').validate();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define the selector in the configuration block.
Also, all variable declaration should be on the top of the function.

@VladimirZaets
Copy link
Contributor

@vishesh-webkul , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented Nov 11, 2019

Hi @vishesh-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VladimirZaets VladimirZaets self-assigned this Nov 11, 2019
@ghost ghost mentioned this pull request Nov 20, 2019
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@rodrigowebjump rodrigowebjump

@VladimirZaets VladimirZaets

Labels
Area: Frontend Component: Wishlist Progress: needs update Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ihor-sviziev @sidolov @rodrigowebjump @magento-engcom-team @VladimirZaets