Skip to content

Warning when Search Terms page is opened by clicking option at the footer #25246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from Feb 13, 2020
Merged

Warning when Search Terms page is opened by clicking option at the footer #25246

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b3bd36
#25245 fixed
Oct 23, 2019
c7483ba
Merge branch '2.4-develop' of https://github.com/magento/magento2 int…
Nazar65 Feb 7, 2020
7b99e51
reafactoring, declare empty array variable
Nazar65 Feb 7, 2020
c58a7e3
small improvements
Nazar65 Feb 7, 2020
1e14f00
revert param type
Nazar65 Feb 7, 2020
1760043
cover changes with unit test
Nazar65 Feb 7, 2020
d1f1eba
remove unesscesary check
Nazar65 Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/code/Magento/Search/Block/Term.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ protected function _loadTerms()
$temp[$term->getQueryText()] = $term;
$termKeys[] = $term->getQueryText();
}
if (empty($termKeys)) {
return $this;
}
natcasesort($termKeys);

foreach ($termKeys as $termKey) {
Expand Down