-
Notifications
You must be signed in to change notification settings - Fork 9.4k
upgrade method delete by ids to inject array skus #25249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 14 commits into
magento:2.4-develop
from
sarron93:2.3-develop
Feb 13, 2020
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c5eb623
upgrade method delete by ids to inject array skus
sarron93 3558184
refactor getByIds method and use object manager into constructor class
sarron93 98e0613
add constructor parameter
sarron93 7885d47
return changes and add additional interface for CategoryLinkRepository
sarron93 c50bb9a
change interface name
sarron93 00db642
add auto tests
sarron93 fda5b4d
add return function type
sarron93 2324cdd
Merge branch '2.4-develop' into 2.3-develop
p-bystritsky 00750f4
fix static
engcom-Charlie 5b3a131
magento/magento2#25249: fix static
engcom-Charlie f686865
magento/magento2#25249: fix cs
engcom-Charlie 3fdeb7f
fix Unit test case and add throw exception into method declaration
sarron93 92b3468
mend
sarron93 128535f
add preferences to di
sarron93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
app/code/Magento/Catalog/Api/CategoryListDeleteBySkuInterface.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?php | ||
| /** | ||
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
|
|
||
| namespace Magento\Catalog\Api; | ||
|
|
||
| /** | ||
| * @api | ||
| * @since 100.0.2 | ||
| */ | ||
| interface CategoryListDeleteBySkuInterface | ||
| { | ||
| /** | ||
| * delete by skus list | ||
| * | ||
| * @param int $categoryId | ||
| * @param array $productSkuList | ||
| * @return bool | ||
| * | ||
| * @throws \Magento\Framework\Exception\CouldNotSaveException | ||
ihor-sviziev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @throws \Magento\Framework\Exception\InputException | ||
| */ | ||
| public function deleteBySkus($categoryId, array $productSkuList); | ||
ihor-sviziev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.