TASK || Left Side Back End Menu Design fix #18687

[angelgonzalezi4]

Is a fix to the task Left Side Back End Menu Design fix #18687
URL: #18687

Description (*)

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @angelgonzalezi4. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @kalpmehta, thank you for the review.
ENGCOM-6187 has been created to process this Pull Request

[kalpmehta]

Thanks @angelgonzalezi4 for your contribution. I have tested this on one of the website I manage which had this issue for long time, it works like a charm!

[dmytro-ch]

Hello @angelgonzalezi4,
could you please also fix the code styling issues reported by Static Test?
Thank you!

[dmytro-ch]

I guess It's better to use the corresponding mixin:

Suggested change

	display: inline-flex;
	.lib-vendor-prefix-display(inline-flex);

[dmytro-ch]

Suggested change

	flex-wrap: wrap;
	.lib-vendor-prefix-flex-wrap(wrap);

[kalpmehta]

Hi @angelgonzalezi4, can you please make the changes suggested by @dmytro-ch ? I would love to see this getting merged.

[angelgonzalezi4]

Until the weekend most probably i cant do It bit i Will try it :S El mié., 13 nov. 2019 5:00, Kalpesh Mehta <[email protected]> escribió:

…

Hi @angelgonzalezi4 <https://github.com/angelgonzalezi4>, can you please make the changes suggested by @dmytro-ch <https://github.com/dmytro-ch> ? I would love to see this getting merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25319?email_source=notifications&email_token=ANTK6AC43FU7KZEO5DHN6ALQTN3VTA5CNFSM4JFRZGP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED4ZPVY#issuecomment-553228247>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANTK6AENJCUB3URNHD33BPTQTN3VTANCNFSM4JFRZGPQ> .

[VladimirZaets]

@angelgonzalezi4 , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

[m2-assistant]

Hi @angelgonzalezi4, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.