TinyMCE4 hard to input double byte characters on chrome

[HirokazuNishi]

Description (*)

As @Consumewithadele described on #24637, Magento2.3 with TinyMCE4 has serious issue on Chrome and double byte characters. This fix aims to be able to work the feature as expected on Chrome.

Fixed Issues (if relevant)

1. Chinese input in tinymce 4 #24637: Chinese input in tinymce 4

Manual testing scenarios (*)

1. Open Magento admin panel via Google Chrome.
2. Create new cms page
3. Turn on Google IME or MS-IME (or others)
4. Input double byte characters
5. Insert widgets and continue typing

Questions or comments

fixRangeSelection function was added for fixing Page Builder related issue. Even though remove the code, Page Builder works as expected. Is this function still needed?

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @HirokazuNishi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[krzksz]

@magento give me test instance

[magento-engcom-team]

Hi @krzksz. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @krzksz, here is your new Magento instance.
Admin access: https://pr-25454.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[krzksz]

I have tested the changes you did and in fact the issue that was mentioned in #24637 (comment) no longer persists even with this line commented out. In that case it would be best to remove this call and whole fixRangeSelection function from this file instead of commenting it out.

[krzksz]

Hey @HirokazuNishi, is it possible for you to make the suggested change? Are you still willing to work on this?

[ihor-sviziev]

I believe it will be too hard to cover this case with automation test and author isn’t responding for a long time so I believe he’ll not cover it.
Approving this PR as is

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7045 has been created to process this Pull Request

[krzksz]

Thanks for adjusting it @ihor-sviziev!

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-7045 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @HirokazuNishi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.