Skip to content

Add Poland regions #25590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Nov 13, 2019

Description (*)

Currently there are only few countries which have prefilled regions in Magento. This PR adds regions for Poland

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Go to either checkout or customer address edit
  2. Select Poland as country and observer regions field - it should be select with regions allowed

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2019

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6281 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@ghost ghost assigned dmytro-ch Nov 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6281 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Nov 15, 2019
@magento-engcom-team magento-engcom-team merged commit 544cb02 into magento:2.3-develop Nov 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2019

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 15, 2019
@Bartlomiejsz Bartlomiejsz deleted the feature/add_poland_regions branch November 22, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants