Skip to content

M2C-21768 Validate product quantity on Wishlist update #25641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2020
Merged

M2C-21768 Validate product quantity on Wishlist update #25641

merged 4 commits into from
Feb 9, 2020

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Nov 18, 2019

Description (*)

I've added a method which validates product qty in order to prevent updating Wishlist with product quantity that is empty, 0 or negative number.

Fixed Issues (if relevant)

  1. Display some error "We can't update your Wish List right now." at wish list #25032: Display some error "We can't update your Wish List right now." at wish list

Manual testing scenarios (*)

  1. Add product to Wishlist
  2. Go to Wishlist
  3. Edit the product from Wishlist
  4. On detail page leave qty blank, add 0 or negative number and click on Update Wishlist button.
  5. Error message should appear.

image

Questions or comments

The same behaviour works for updating products quantity in Wishlist in User Area.

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ptylek ptylek requested a review from DrewML as a code owner November 18, 2019 16:03
@m2-assistant
Copy link

m2-assistant bot commented Nov 18, 2019

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

krzksz
krzksz suggested changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@krzksz krzksz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ptylek, thanks for the contribution! Please check the tests results and fix the code accordingly.

@ptylek ptylek closed this Nov 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 19, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ptylek ptylek reopened this Nov 19, 2019
@Karlasa Karlasa self-assigned this Nov 20, 2019
Karlasa
Karlasa suggested changes Nov 20, 2019
View reviewed changes
@krzksz
Copy link
Contributor

krzksz commented Nov 20, 2019

@magento run all tests

@Karlasa
Copy link
Contributor

Karlasa commented Nov 20, 2019

will re-open PR to see if it fixes the issue with failed test.

@Karlasa Karlasa closed this Nov 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Karlasa Karlasa reopened this Nov 20, 2019
@ghost ghost unassigned Karlasa Nov 20, 2019
@Karlasa Karlasa self-assigned this Nov 20, 2019
@ptylek ptylek closed this Nov 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ptylek ptylek reopened this Nov 20, 2019
@ghost ghost unassigned Karlasa Nov 20, 2019
@ghost ghost unassigned Karlasa Nov 20, 2019
@ghost
Copy link

ghost commented Nov 20, 2019

@ptylek unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ptylek
Copy link
Contributor Author

ptylek commented Nov 20, 2019

@Karlasa I tried to close and reopen it once again, without success.

@Karlasa Karlasa self-assigned this Nov 20, 2019
@Karlasa
Copy link
Contributor

Karlasa commented Nov 21, 2019

@engcom-Alfa Could you provide some insights why static tests are failing without giving any feedback about it?

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Nov 21, 2019 •
edited
Loading

@Karlasa There are many static errors in the add-to-wishlist.js file.
The errors are not displayed because they do not fit into the report frame.

@ptylek
Copy link
Contributor Author

ptylek commented Nov 21, 2019

@engcom-Alfa I fixed those error. All checks have passed.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12
@engcom-Golf engcom-Golf self-assigned this Jan 14, 2020
@engcom-Golf
Copy link
Contributor

I will take care of test coverage

@engcom-Golf engcom-Golf added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 14, 2020
@engcom-Golf
Copy link
Contributor

Hi @krzksz changes covered by jasmine test, could you please review ?

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6305 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka slavvka mentioned this pull request Feb 9, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
ENGCOM-6305: M2C-21768 Validate product quantity on Wishlist update #…
a0ceb97 
…25641
@magento-engcom-team magento-engcom-team merged commit b398206 into magento:2.4-develop Feb 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzksz krzksz krzksz approved these changes

@Karlasa Karlasa Karlasa approved these changes

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@krzksz krzksz

@Karlasa Karlasa

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Wishlist Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ptylek @krzksz @Karlasa @magento-engcom-team @engcom-Alfa @engcom-Golf @sidolov @Nazar65