-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Prevent RequireJS from adding .min.js suffix to external files #25869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent RequireJS from adding .min.js suffix to external files #25869
Conversation
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
80f7053
to
f84b5b1
Compare
f84b5b1
to
23f0ced
Compare
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
Hi @krzksz, thank you for your contribution! |
Description (*)
This commit adds and additional check if file belongs to current base URL before setting
min.js
suffix.Fixed Issues (if relevant)
Manual testing scenarios (*)
require(['https://magento.com/test.js'], console.log);
.test.js
and not fortest.min.js
.Contribution checklist (*)