Prevent endless loop when duplicating product

[JeroenVanLeusden]

Description (*)

Duplicating product will end up in endless loop which also keeps copying product images.

Fixed Issues (if relevant)

1. Duplicating product copies product images couple of hundred times #9466: Duplicating product copies product images couple of hundred times (not sure if fully fixed by definitely related)

Manual testing scenarios (*)

1. Create simple product with tier prices.
2. Create 2nd store.
3. Change url key of created simple on 2nd store scope.
4. Change to default scope and save & duplicate product.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @JeroenVanLeusden,
In general your changes looks good for me. Could you adjust your code according to my comment above and cover your changes with some test in order not to have regression in future?

[ihor-sviziev]

Hi @JeroenVanLeusden,
Will you be able to update your PR? This is quite good improvement, I'd like to accept it.

[JeroenVanLeusden]

Yes definitely! Didn't had time to update it yet, will try to find some soon.

[JeroenVanLeusden]

@ihor-sviziev Added stopper and a testcase.

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Failing unit tests are not related to changes from this PR

[engcom-Delta]

✔️ QA passed

[ihor-sviziev]

Missed to add - failing functional tests looks not related to changes from this PR

[lenaorobei]

Please see my comment regarding BC.
It should be avoided in the scope of 2.4-develop.

[ihor-sviziev]

@magento run all tests

[m2-assistant]

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[maxq]

Not being much of a coder I have to ask how do I get the updated copier.php file? I presume I can just replace the fixed file in the 2.3.4 installation?

[PsmIndia]

Need Urgent Help, magento setup version is 2.3.4[upgraded m1], we have "29542 records found" products, i am facing duplicate product issue, try to fix using available patch but its not fix.

Today i remove all products images in test environment, there no image for a single product, now i add product image for a single product, i save it, working cool, but when i try to do duplicate this product, its again went into infinite loop, within few mints it create huge[4.3GB] garbage of that image that recently add. now i am helpless.