Skip to content

Resolve "Layered Navigation Price Step" in Category Form display wrong currency issue25970 #25971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Resolve "Layered Navigation Price Step" in Category Form display wrong currency issue25970 #25971

wants to merge 3 commits into from

Conversation

edenduong
Copy link
Contributor

@edenduong edenduong commented Dec 10, 2019 •
edited
Loading

Description (*)

  1. Resolve "Layered Navigation Price Step" in Category Form display wrong currency #25970 Currency sign for "Layered Navigation Price Step" is not according to default settings #21684: "Layered Navigation Price Step" in Category Form display wrong currency

Fixed Issues (if relevant)

  1. "Layered Navigation Price Step" in Category Form display wrong currency #25970: "Layered Navigation Price Step" in Category Form display wrong currency
  2. Currency sign for "Layered Navigation Price Step" is not according to default settings #21684: Currency sign for "Layered Navigation Price Step" is not according to default settings

Manual testing scenarios (*)

  1. Go to backend
  2. Set default currency to Euro

image

  1. Go to Catalog->Categories
  2. Edit one category, scroll to Display Settings
  3. See:

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@edenduong edenduong requested a review from akaplya as a code owner December 10, 2019 10:29
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Dec 10, 2019
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Award: bug fix labels Dec 11, 2019
@dmytro-ch
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-25971.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6451 has been created to process this Pull Request

@dmytro-ch
Copy link
Contributor

@edenduong, thank you for the MFTF test. Well done!

@engcom-Charlie engcom-Charlie self-assigned this Dec 18, 2019
@engcom-Charlie engcom-Charlie removed their assignment Dec 18, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jan 8, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jan 8, 2020 •
edited
Loading

Hi @edenduong
This issues (#25970 , #21684) were already fixed by PR #24815.

Actual Result:
before

So, we have to close it.
@edenduong Thank you for your contribution!

@engcom-Alfa engcom-Alfa closed this Jan 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: category of expertise Award: MFTF test coverage Component: Catalog Progress: testing in progress Release Line: 2.4 tech-partners-contribution Technology Partner: Magestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Layered Navigation Price Step" in Category Form display wrong currency
5 participants
@edenduong @dmytro-ch @magento-engcom-team @engcom-Alfa @engcom-Charlie