Skip to content

[WishlistGraphQL] Covering the CustomerWishlistResolver #26125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Goal of this PR is improving test coverage for WishlistGraphQL module by covering the \Magento\WishlistGraphQl\Model\Resolver\CustomerWishlistResolver by Unit Tests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Execute Unit Tests for WishlistGraphQl module

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Strix partners-contribution Pull Request is created by Magento Partner labels Dec 19, 2019
@dmytro-ch dmytro-ch self-assigned this Dec 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6502 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Dec 19, 2019
@engcom-Alfa engcom-Alfa self-assigned this Dec 19, 2019
@engcom-Alfa
Copy link
Contributor

QA not applicable

@lenaorobei
Copy link
Contributor

Hi @lbajsarowicz. There is no need to cover GraphQL resolvers with unit test, since it is already covered with api-functional tests. If some cases are not covered please consider writing api-functional test.
Thanks.

@m2-assistant
Copy link

m2-assistant bot commented Dec 29, 2019

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants