Skip to content

magento/magento2#: Test Coverage. API functional tests. removeItemFromCart #26563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2020
Merged

magento/magento2#: Test Coverage. API functional tests. removeItemFromCart #26563

merged 3 commits into from
Mar 12, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jan 28, 2020 •
edited
Loading

Description (*)

PR adds a test coverage for the next exceptions of removeItemFromCart mutation:

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2020
@atwixfirster atwixfirster force-pushed the api-functional-graphql-removeItemFromCart branch from 529faf7 to 3685d7b Compare January 28, 2020 16:27
@dmytro-ch dmytro-ch self-assigned this Jan 28, 2020
@atwixfirster atwixfirster force-pushed the api-functional-graphql-removeItemFromCart branch from 3685d7b to d64082f Compare January 28, 2020 19:11
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Mar 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7020 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

dmytro-ch
dmytro-ch requested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @atwixfirster, could you please update your working branch with the latest changes from 2.4-develop and fix static test?

@atwixfirster
Copy link
Contributor Author

Hello @atwixfirster, could you please update your working branch with the latest changes from 2.4-develop and fix static test?

done

@ghost ghost assigned lenaorobei Mar 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7020 has been created to process this Pull Request

@ghost ghost added the Progress: accept label Mar 9, 2020
magento-engcom-team pushed a commit that referenced this pull request Mar 12, 2020
@slavvka
ENGCOM-7020: magento/magento2#: Test Coverage. API functional tests. …
85716b7 
…removeItemFromCart #26563
@magento-engcom-team magento-engcom-team merged commit e1fb9de into magento:2.4-develop Mar 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch requested changes

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@dmytro-ch dmytro-ch

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atwixfirster @magento-engcom-team @dmytro-ch @lenaorobei