Skip to content

Unit test for \Magento\Captcha\Observer\ResetAttemptForBackendObserver and ResetAttemptForFrontendObserver #26715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 2 commits into from
Feb 13, 2020
Merged

Unit test for \Magento\Captcha\Observer\ResetAttemptForBackendObserver and ResetAttemptForFrontendObserver #26715

magento-engcom-team merged 2 commits into from
Feb 13, 2020

Conversation

@karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Feb 5, 2020

Description (*)

Covers \Magento\Captcha\Observer\ResetAttemptForBackendObserver and \Magento\Captcha\Observer\ResetAttemptForFrontendObserver with Unit tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@karyna-t
Unit test for \Magento\Captcha\Observer\ResetAttemptForBackendObserve…
10363f5 
…r and \Magento\Captcha\Observer\ResetAttemptForFrontendObserver
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2020

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Captcha Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 5, 2020
@rogyar rogyar self-assigned this Feb 5, 2020
rogyar
rogyar suggested changes Feb 5, 2020
View reviewed changes
app/code/Magento/Captcha/Test/Unit/Observer/ResetAttemptForBackendObserverTest.php Outdated
ResetAttemptForBackendObserver::class,
['resLogFactory' => $resLogFactoryMock]
);
$observer->execute($eventObserverMock);
Copy link
Contributor

@rogyar rogyar Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the execute method returns a value, it makes sense to add the corresponding assertion.

Copy link
Contributor Author

@karyna-t karyna-t Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

app/code/Magento/Captcha/Test/Unit/Observer/ResetAttemptForFrontendObserverTest.php Outdated
ResetAttemptForFrontendObserver::class,
['resLogFactory' => $resLogFactoryMock]
);
$observer->execute($eventObserverMock);
Copy link
Contributor

@rogyar rogyar Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the execute method returns a value, it makes sense to add the corresponding assertion.

Copy link
Contributor Author

@karyna-t karyna-t Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@engcom-Echo engcom-Echo self-assigned this Feb 6, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 9, 2020
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 9, 2020

Hi @rogyar, thank you for the review.
ENGCOM-6835 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Feb 10, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 10, 2020

✔️ QA Passed

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2020
@slavvka
ENGCOM-6835: Unit test for \Magento\Captcha\Observer\ResetAttemptForB…
dc58146 
…ackendObserver and ResetAttemptForFrontendObserver #26715
@magento-engcom-team magento-engcom-team merged commit ea00720 into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-t karyna-t deleted the unit-test-captcha-observers-reset-attempt-for-backend-and-frontend branch August 6, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogyar rogyar rogyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Captcha Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@karyna-t @magento-engcom-team @engcom-Alfa @rogyar @engcom-Echo