Skip to content

Module_Cms MFTF test improvements #26782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 2 commits into from
Feb 13, 2020
Merged

Module_Cms MFTF test improvements #26782

magento-engcom-team merged 2 commits into from
Feb 13, 2020

Conversation

@ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Feb 9, 2020 •
edited
Loading

Description (*)

  1. AdminCreateCmsPageTest doesn't have delete action, after creating a CMS page. Added a CMS page delete action in the existing test.
  2. A single test file contains multiple tests. So moved the test to separate files to follow best practices.

Manual testing scenarios (*)

  1. Run the AdminCreateCmsPageTest in the local environment and verified test is running.
  2. Run the AdminCreateDuplicatedCmsPageTest in the local environment and verified test is running.
  3. Run the AdminConfigDefaultCMSPageLayoutFromConfigurationSettingTest in the local environment and verified test is running.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ajithkumar-maragathavel ajithkumar-maragathavel changed the title Delete action added for CMS page creation MTFT test Module_Cms MFTF test improvements Feb 9, 2020
@rogyar rogyar self-assigned this Feb 9, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 9, 2020
@rogyar
Copy link
Contributor

rogyar commented Feb 9, 2020

Hi @ajithkumar-maragathavel. Thank you for your collaboration. In your next PRs you can also consider rebuilding the tests according to the best practices. For example, building a test body using action groups only. But keep backward compatibility in mind.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 9, 2020

Hi @rogyar, thank you for the review.
ENGCOM-6838 has been created to process this Pull Request

@ajithkumar-maragathavel
Copy link
Contributor Author

ajithkumar-maragathavel commented Feb 9, 2020

@rogyar I will update the test using only the action group in my next PR. Thanks for the review and providing the best practices link.

lbajsarowicz
lbajsarowicz approved these changes Feb 9, 2020
View reviewed changes
app/code/Magento/Cms/Test/Mftf/Test/AdminCreateDuplicatedCmsPageTest.xml
</annotations>
<before>
<actionGroup ref="LoginActionGroup" stepKey="loginGetFromGeneralFile"/>
<actionGroup ref="DisabledWYSIWYGActionGroup" stepKey="disableWYSIWYG"/>
Copy link
Contributor

@lbajsarowicz lbajsarowicz Feb 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar I don't remember, but it's no longer necessary to add this. How do you think?

@ghost ghost assigned lbajsarowicz Feb 9, 2020
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 9, 2020

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6838 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 10, 2020
@engcom-Delta
Copy link
Contributor

engcom-Delta commented Feb 10, 2020

Notice: QA not applicable

@engcom-Echo engcom-Echo self-assigned this Feb 10, 2020
@lenaorobei lenaorobei removed the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 10, 2020
@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 10, 2020
magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2020
@slavvka
ENGCOM-6838: Module_Cms MFTF test improvements #26782
b80e6f6
@magento-engcom-team magento-engcom-team merged commit eff07be into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kieuphan2406 kieuphan2406 Awaiting requested review from kieuphan2406

@tomreece tomreece Awaiting requested review from tomreece

2 more reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@rogyar rogyar rogyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lbajsarowicz lbajsarowicz

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Cms Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ajithkumar-maragathavel @rogyar @magento-engcom-team @engcom-Delta @lbajsarowicz @lenaorobei @engcom-Echo