Skip to content

Conversation

@karyna-t
Copy link
Contributor

Description (*)

Covers Magento\Directory\Block\Adminhtml\Frontend\Currency\Base wit a unit test.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 11, 2020

Hi @karyna-tsymbal-atwix. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Directory Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 11, 2020
@novikor novikor self-assigned this Feb 11, 2020
Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @karyna-tsymbal-atwix! Thank you for your contribution.
Seems fine, - I'll put the PR on hold until the Functional tests build are green (there is a problem with 2.4-develop currently), and approve then.

Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plans have changed)

@magento-engcom-team
Copy link
Contributor

Hi @novikor, thank you for the review.
ENGCOM-6868 has been created to process this Pull Request
✳️ @novikor, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@novikor novikor added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 11, 2020
@karyna-t
Copy link
Contributor Author

@novikor thank you!

@magento-engcom-team magento-engcom-team merged commit 5d0dfb5 into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @karyna-tsymbal-atwix, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@karyna-t karyna-t deleted the unit-test-directory-block-currency-base branch August 6, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Directory Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants