Skip to content

security-package/issues/115: Fix AdminSessionsManagerTest and AuthSessionTest. #26910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

p-bystritsky
Copy link
Contributor

Description (*)

Fix required for magento/security-package builds stabilization.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fix AdminSessionsManagerTest and AuthSessionTest. security-package#115

Manual testing scenarios (*)

  1. None

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2020

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost
Copy link

ghost commented Feb 18, 2020

@p-bystritsky unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@ghost ghost assigned p-bystritsky Feb 18, 2020
@ghost
Copy link

ghost commented Feb 18, 2020

@p-bystritsky unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

@p-bystritsky p-bystritsky requested a review from naydav February 18, 2020 15:06
@p-bystritsky p-bystritsky removed their assignment Feb 18, 2020
@ghost ghost assigned p-bystritsky Feb 18, 2020
@ghost
Copy link

ghost commented Feb 18, 2020

@p-bystritsky unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

@p-bystritsky p-bystritsky removed their assignment Feb 24, 2020
@ghost ghost assigned p-bystritsky Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

@p-bystritsky unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Mar 4, 2020

@magento run Unit Tests

For sure unit tests can't start failing when only integration tests were changed.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7031 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 4, 2020
@engcom-Alfa engcom-Alfa self-assigned this Mar 5, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@naydav
Copy link
Contributor

naydav commented Mar 9, 2020

Fixed in scope of magento/security-package#124

@naydav naydav closed this Mar 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 9, 2020

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants