Skip to content

Cleanup ObjectManager usage - Magento_Elasticsearch #26964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Feb 21, 2020

Description (*)

This PR cleanups ObjectManager usage in Magento_Elasticsearch, adds additional dependencies with backward compatibility to api classes, and removes object manager instantiation from non-api classes

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_elasticsearch branch from 97edbb5 to 7c92915 Compare February 21, 2020 23:26
@Bartlomiejsz Bartlomiejsz force-pushed the feature/dependencies_into_constructor_elasticsearch branch from 7c92915 to 26ff555 Compare February 21, 2020 23:57
@Bartlomiejsz Bartlomiejsz marked this pull request as ready for review February 22, 2020 23:07
@magento-engcom-team
Copy link
Contributor

Hi @pmclain, thank you for the review.
ENGCOM-6973 has been created to process this Pull Request
✳️ @pmclain, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Charlie engcom-Charlie self-assigned this Mar 3, 2020
@engcom-Charlie engcom-Charlie added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 3, 2020
@magento-engcom-team magento-engcom-team merged commit db8db46 into magento:2.4-develop Mar 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/dependencies_into_constructor_elasticsearch branch June 23, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Elasticsearch Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants