Skip to content

Removed redundant method _beforeToHtml #27057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Removed redundant method _beforeToHtml #27057

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e99f36f
Removed redundant method _beforeToHtml
Usik2203 Feb 27, 2020
bfe4693
Fixed codestyle issue
Usik2203 Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions app/code/Magento/Newsletter/Block/Adminhtml/Subscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,18 @@
*/
namespace Magento\Newsletter\Block\Adminhtml;

use Magento\Backend\Block\Template;
use Magento\Backend\Block\Template\Context;
use Magento\Newsletter\Model\ResourceModel\Queue\Collection;
use Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory;

/**
* Newsletter Subscriber block
*
* @api
* @since 100.0.2
*/
class Subscriber extends \Magento\Backend\Block\Template
class Subscriber extends Template
{
/**
* Queue collection
Expand All @@ -32,34 +37,24 @@ class Subscriber extends \Magento\Backend\Block\Template
protected $_template = 'Magento_Newsletter::subscriber/list.phtml';

/**
* @var \Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory
* @var CollectionFactory
*/
protected $_collectionFactory;

/**
* @param \Magento\Backend\Block\Template\Context $context
* @param \Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory $collectionFactory
* @param Context $context
* @param CollectionFactory $collectionFactory
* @param array $data
*/
public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\Newsletter\Model\ResourceModel\Queue\CollectionFactory $collectionFactory,
Context $context,
CollectionFactory $collectionFactory,
array $data = []
) {
$this->_collectionFactory = $collectionFactory;
parent::__construct($context, $data);
}

/**
* Prepares block to render
*
* @return $this
*/
protected function _beforeToHtml()
{
return parent::_beforeToHtml();
}

/**
* Return queue collection with loaded neversent queues
*
Expand All @@ -68,7 +63,7 @@ protected function _beforeToHtml()
public function getQueueCollection()
{
if ($this->_queueCollection === null) {
/** @var $this->_queueCollection \Magento\Newsletter\Model\ResourceModel\Queue\Collection */
/** @var $this->_queueCollection Collection */
$this->_queueCollection = $this
->_collectionFactory
->create()
Expand Down