-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Cleanup ObjectManager usage - Magento_Analytics #27082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ObjectManager usage - Magento_Analytics #27082
Conversation
Hi @Bartlomiejsz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @aleron75, thank you for the review. |
✔️ QA Passed |
app/code/Magento/Analytics/Block/Adminhtml/System/Config/CollectionTimeLabel.php
Outdated
Show resolved
Hide resolved
…ctionTimeLabel.php
Hi @Bartlomiejsz, thank you for your contribution! |
Description (*)
This PR cleanups ObjectManager usage in Magento_Analytics, by removing object manager instantiation from non-api classes
Related Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)