magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver

[atwixfirster]

Description (*)

PR removes a redundant logic in the SetShippingMethodsOnCart mutation resolver because Webonix covers the next cases:

• shipping_methods.carrier_code does not exist

• shipping_methods.method_code does not exist

Related Pull Requests

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver #28262: magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver

Resolved issues:

1. resolves [Issue] magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver #28427: magento/magento2#: GraphQl. Remove a redundant logic in “SetShippingMethodsOnCart” mutation resolver

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[atwixfirster]

@rogyar , could you please review this PR because failed static tests are not tie to the provided changes.

Thank you!

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7216 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

After:

Case 1

method_code doesn't exist

Request:

mutation {
setShippingMethodsOnCart(input: {
  cart_id: "IIHXzIYP2HelB7xerWpZN1h4EZU7wxk4"
  shipping_methods:
  [
    {
      carrier_code: "ups"
    }
  ]
}) {
  cart {
    shipping_addresses {
      selected_shipping_method {
        carrier_code
        method_code
        carrier_title
        method_title
      }
    }
  }
}
}

Response:

{
  "errors": [
    {
      "message": "Field ShippingMethodInput.method_code of required type String! was not provided.",
      "extensions": {
        "category": "graphql"
      },
      "locations": [
        {
          "line": 2,
          "column": 100
        }
      ]
    }
  ]
}

Case 2

carrier_code doesn't exist

Request:

mutation {
setShippingMethodsOnCart(input: {
  cart_id: "IIHXzIYP2HelB7xerWpZN1h4EZU7wxk4"
  shipping_methods:
  [
    {
      method_code: "GND"

    }
  ]
}) {
  cart {
    shipping_addresses {
      selected_shipping_method {
        carrier_code
        method_code
        carrier_title
        method_title
      }
    }
  }
}
}

Response:

{
  "errors": [
    {
      "message": "Field ShippingMethodInput.carrier_code of required type String! was not provided.",
      "extensions": {
        "category": "graphql"
      },
      "locations": [
        {
          "line": 2,
          "column": 100
        }
      ]
    }
  ]
}

[slavvka]

@magento create issue

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7216 has been created to process this Pull Request

[VladimirZaets]

@magento create issue

[avattam06]

@magento run all tests

[avattam06]

@magento run all tests

[avattam06]

@magento run integration tests

[avattam06]

@magento run all tests

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.