Resolved Cannot create shipment for remaining items

[niravkrish]

Description (*)

Steps to Reproduce (*)

Create an order, where at least one product has a Quantity of 2.

Example of order items : - 3 x product_1

• 1 x product_2
• 1 x product_3
  Create an invoice, shipment and creditmemo for:
• 2 x product_1
• 1 x product_2
• 1 x product_3

Fixed Issues (if relevant)

1. Cannot create shipment for remaining items #27141: Cannot create shipment for remaining items

Manual testing scenarios (*)

1. Manual testing

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lenaorobei]

Hi @niravkrish,

Thanks for your contribution. Please address builds failures and consider adding some tests to verify expected behaviour.

[niravkrish]

Hi @niravkrish,

Thanks for your contribution. Please address builds failures and consider adding some tests to verify expected behaviour.

Hello @lenaorobei
I have resolved unit testing.
can you please assist me how to solve rest of the failed test cases.
I am not able to figure out the failed test cases.

Thank you

[ihor-sviziev]

@niravkrish I just fixed static test, looks like failing functional tests were false positives. I'll review this PR again when all tests will be finished

[ihor-sviziev]

✔ Approved

Failing tests looks not related to changes from this PR.

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create Order with items (for ex.);

• Product 1 - 3 pcs.;
• Product 2 - 1 pcs.;
• Product 3 - 1 pcs.;

2. Create an invoice, shipment and credit memo for:

• Product 1 - 2 pcs.;
• Product 2 - 1 pcs.;
• Product 3 - 1 pcs.;

3. Try to create a shipment for remaining items;

Before: ✖️ The Ship button disappeared

After: ✔️ The Ship button appeared and it became possible to create a shipment for remaining items

[engcom-Charlie]

Failed functional tests not related to the changes in this PR

[slavvka]

@niravkrish @ihor-sviziev needs to be eretested after PHP 7.4 support is merged

[ihor-sviziev]

Failed tests not related to changes from this PR.
Approved ✔

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7526 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create Order with items (for example);

• Product 1 - 3 pcs.;
• Product 2 - 1 pcs.;
• Product 3 - 1 pcs.;

2. Create an invoice, shipment and credit memo for:

• Product 1 - 2 pcs.;
• Product 2 - 1 pcs.;
• Product 3 - 1 pcs.;

3. Try to create a shipment for remaining items;

Actual Result:

✔️ The Ship button appeared and it became possible to create a shipment for remaining items

[engcom-Charlie]

Failed test not related to changes from this PR.

[m2-assistant]

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.