[Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select by vasilii-b · Pull Request #27417 · magento/magento2

vasilii-b · 2020-03-24T17:08:38Z

Description (*)

This PR aims to add a new validation for the options of the product attribute type "Dropdown", "Multiple Select" that checks whenever the option value contains HTML tags.

HTML tags are not useful nor displayed on the storefront for the product attribute options, those the store manager should be aware of it.

Related Pull Requests

#27371

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Go to the Admin area
Go to Stores -> Attributes -> Product
Press the button "Add New Attribute"
Fill in the attribute default label
Select the "Catalog Input Type for Store Owner" to "Dropdown" or "Multiple Select"
In the section "Manage Options (Values of Your Attribute)" below add new options that contain HTML tags like <span>, </strong>, etc.
Press the "Save and Continue Edit" or "Save Attribute" button
See the error message

Questions or comments

Are the provided Unit and MFTF tests enough or there should be done more?

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select #29602: [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select

m2-assistant · 2020-03-24T17:08:41Z

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

vasilii-b · 2020-03-24T17:22:54Z

@magento run all tests

…ML tags usage

And solve minor conflicts on the MFTF action groups

rogyar · 2020-04-08T07:44:38Z

@magento run all tests

rogyar · 2020-04-13T08:36:28Z

Hi @vasilii-b. Considering the fact that the only static tests were executed we can assume that Magento cannot be installed after the change you've provided (theoretically). I would recommend doing the following for confirming this assumption.

Switch to the 2.4-develop branch
Pull the latest changes
Merge your branch into the 2.4-develop branch
Run Magento installation with a clean database (via CLI)
Make sure that Magento is installed successfully

vasilii-b · 2020-04-13T08:38:04Z

Hi @rogyar,
Thank you so much! I'll give it a try.

sidolov · 2020-08-17T16:24:12Z

@magento create issue

sidolov · 2020-08-21T19:25:40Z

app/code/Magento/Eav/Model/Validator/Attribute/Options.php

+    /**
+     * Validation pattern for attribute options HTML tags
+     */
+    const VALIDATION_HTML_TAGS_RULE_PATTERN = '/<[^<]+>/';


Please, make const private

sidolov · 2020-08-21T19:25:44Z

app/code/Magento/Eav/Model/Validator/Attribute/Options.php

+    /**
+     * Validation message for attribute options with HTML tags
+     */
+    const VALIDATION_HTML_TAGS_RULE_MESSAGE = 'HTML tags are not allowed for the attribute options. '.


Please, make const private

sidolov

Please, take a look at the review comments

…for-dropdown-options # Conflicts: # app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Attribute/ValidateTest.php

…t attribute options when type is dropdown or multiple select.

engcom-Foxtrot · 2020-09-11T09:20:55Z

@magento run all tests

engcom-Foxtrot · 2020-09-11T12:20:12Z

@magento run all tests

gabrieldagama · 2020-09-14T10:29:03Z

@magento run all tests

engcom-Foxtrot · 2020-09-16T11:39:39Z

@magento run all tests

…t attribute options when type is dropdown or multiple select - installation fix.

engcom-Foxtrot · 2020-09-18T12:33:28Z

@magento run all tests

…for-dropdown-options

engcom-Foxtrot · 2020-10-13T10:01:34Z

@magento run all tests

…for-dropdown-options

engcom-Foxtrot · 2020-10-29T07:49:17Z

@magento run all tests

engcom-Charlie · 2020-11-02T13:40:13Z

Before changes ✔️

I can create dropdown product attribute with:

Visible on Catalog Pages on Storefront -> Yes
Allow HTML Tags on Storefront -> Yes

And option value with Html tags which visible on PDP

After changes ✖️

I try to create the same attribute and get the following error

@vasilii-b could you please take a look?
Thank you.

engcom-Charlie · 2020-11-16T09:39:01Z

Hi @vasilii-b, I'm closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for your collaboration.

m2-assistant · 2020-11-16T09:39:03Z

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Mar 24, 2020

magento-engcom-team added Area: Frontend Component: Catalog Component: Eav Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 24, 2020

vasilii-b changed the title ~~[Admin] Do not allow HTML tags for product attribute options when type is dropdown or multiple select~~ [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select Mar 24, 2020

rogyar self-assigned this Mar 25, 2020

Validate attribute options (for dropdown, multiselect, swatch) for HT…

ee6a8c8

…ML tags usage

vasilii-b force-pushed the admin-product-attribute-no-html-tags-for-dropdown-options branch from 1280b66 to ee6a8c8 Compare March 25, 2020 16:16

Merge remote-tracking 2.4-develop into the working branch

8ecedd9

And solve minor conflicts on the MFTF action groups

Burlacu Vasilii added 2 commits April 8, 2020 13:43

Removed MFTF test to github tests results

1ac72c1

Removed adjusted Unit test to check github checks results

773e0e9

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020

m2-assistant bot mentioned this pull request Aug 17, 2020

[Issue] [Admin][improvement] Do not allow HTML tags for product attribute options when type is dropdown or multiple select #29602

Closed

4 tasks

sidolov approved these changes Aug 21, 2020

View reviewed changes

ghost assigned sidolov Aug 21, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Aug 21, 2020

sidolov requested changes Aug 21, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels Aug 21, 2020

engcom-Foxtrot self-assigned this Sep 10, 2020

engcom-Foxtrot added 2 commits September 10, 2020 13:40

Merge branch '2.4-develop' into admin-product-attribute-no-html-tags-…

d67def0

…for-dropdown-options # Conflicts: # app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Attribute/ValidateTest.php

magento#29602: [Admin][improvement] Do not allow HTML tags for produc…

52b3d38

…t attribute options when type is dropdown or multiple select.

magento#29602: [Admin][improvement] Do not allow HTML tags for produc…

5270844

…t attribute options when type is dropdown or multiple select - installation fix.

Merge branch '2.4-develop' into admin-product-attribute-no-html-tags-…

ebeb43f

…for-dropdown-options

Merge branch '2.4-develop' into admin-product-attribute-no-html-tags-…

eb43dbf

…for-dropdown-options

engcom-Foxtrot removed their assignment Oct 30, 2020

engcom-Charlie self-assigned this Nov 2, 2020

engcom-Charlie closed this Nov 16, 2020

m2-community-project bot removed the Progress: needs update label Nov 16, 2020

Conversation

vasilii-b commented Mar 24, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 24, 2020

Uh oh!

vasilii-b commented Mar 24, 2020

Uh oh!

rogyar commented Apr 8, 2020

Uh oh!

rogyar commented Apr 13, 2020

Uh oh!

vasilii-b commented Apr 13, 2020

Uh oh!

sidolov commented Aug 17, 2020

Uh oh!

sidolov Aug 21, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Aug 21, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Foxtrot commented Sep 11, 2020

Uh oh!

engcom-Foxtrot commented Sep 11, 2020

Uh oh!

gabrieldagama commented Sep 14, 2020

Uh oh!

engcom-Foxtrot commented Sep 16, 2020

Uh oh!

engcom-Foxtrot commented Sep 18, 2020

Uh oh!

engcom-Foxtrot commented Oct 13, 2020

Uh oh!

engcom-Foxtrot commented Oct 29, 2020

Uh oh!

engcom-Charlie commented Nov 2, 2020

Before changes ✔️

After changes ✖️

Uh oh!

engcom-Charlie commented Nov 16, 2020

Uh oh!

m2-assistant bot commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vasilii-b commented Mar 24, 2020 •

edited by m2-assistant bot

Loading