Fixed issue #19481: After composer installation sample data can't be installed from command line #27481

andrewbess · 2020-03-28T10:37:58Z

Description (*)

This PR fixes the problem when sample data aren't deploying if the field "version" has removed from composer.json.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Magento 2.3.0: After composer installation sampledata can't be installed from command line #19481: Magento 2.3.0: After composer installation sampledata can't be installed from command line

Manual testing scenarios (*)

Install Magento with the composer;
Remove the version number from the composer.json file in the root of the project;
Try to deploy sample data using bin/magento sampledata:deploy

Actual result

Command throws the following error:

bin/magento sampledata:deploy
Git installations must deploy sample data from GitHub; see https://devdocs.magento.com/guides/v2.3/install-gde/install/sample-data-after-clone.html for more information.

The sample data haven't deployed.

Result after fix

Command throws the following message:

bin/magento sampledata:deploy
We don't recommend to remove the "version" field from your composer.json; see https://getcomposer.org/doc/02-libraries.md#library-versioning for more information.
The field "version" has been restored.

The field "version" has been restored in composer.json;
The sample data have been deployed successfully.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

… sampledata can't be installed from command line

m2-assistant · 2020-03-28T10:38:01Z

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz

There's just a minor change + code lint that is going to be detected by Static Tests.
Logic and the approach is - in my opinion - correct. Especially taking into consideration additional notice about missing version node.

lbajsarowicz · 2020-03-28T11:54:19Z

app/code/Magento/SampleData/Console/Command/SampleDataDeployCommand.php

+        $rootJson = json_decode(
+            $this->filesystem->getDirectoryRead(
+                DirectoryList::ROOT
+            )->readFile("composer.json")
+        );


Could you use Json Serializer from Magento package?

Hello @lbajsarowicz
Thank you for your review.
I fixed it. Please check.
Thank you in advance.

lbajsarowicz · 2020-03-28T11:54:45Z

app/code/Magento/SampleData/Console/Command/SampleDataDeployCommand.php

-            $output->writeln('<info>' . 'Git installations must deploy sample data from GitHub; see https://devdocs.magento.com/guides/v2.3/install-gde/install/sample-data-after-clone.html for more information.' . '</info>');
-            return;
+            $magentoProductPackage = array_filter(
+                (array) $rootJson->require,


I'm not sure if you linted your code properly (let's wait for Static tests)

magento-engcom-team · 2020-03-28T12:01:51Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7219 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

lbajsarowicz

The only issue I see is the serializer interface. That should be explicit JSON, as Magento is going to - sooner or later - replace the serializer preference.

lbajsarowicz · 2020-03-28T15:59:54Z

app/code/Magento/SampleData/Console/Command/SampleDataDeployCommand.php

     */
    public function __construct(
        Filesystem $filesystem,
        Dependency $sampleDataDependency,
        ArrayInputFactory $arrayInputFactory,
-        ApplicationFactory $applicationFactory
+        ApplicationFactory $applicationFactory,
+        SerializerInterface $serializer


I think Magento is not the guy you'd like to trust when it comes to Serializer interface :-P
Use the one \Magento\Framework\Serialize\Serializer\Json

Hello @lbajsarowicz
Thank you for your review.
I changed SerializerInterface to Serializer\Json. Please check.
Thank you in advance.

lbajsarowicz · 2020-03-28T16:01:27Z

app/code/Magento/SampleData/Test/Unit/Console/Command/AbstractSampleDataCommandTest.php

+        return [
+            'command' => 'config',
+            'setting-key' => 'version',
+            'setting-value' => ['0.0.1'],
+            '--quiet' => 1
+        ];


That can be just private const STUB_EXPECTED_COMPOSER_CONFIG

Hello @lbajsarowicz
Thank you for your review.
I fixed it. Please check.
Thank you in advance.

magento-engcom-team · 2020-03-28T16:04:40Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7219 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

andrewbess · 2020-03-29T06:53:43Z

app/code/Magento/SampleData/Console/Command/SampleDataDeployCommand.php

     * @return void
     */
    private function updateMemoryLimit()
    {
        if (function_exists('ini_set')) {
-            @ini_set('display_errors', 1);


Hello @lbajsarowicz
I changed @ini_set to ini_alter (that's the alias of ini_set) and added throwing an exception when ini_set returns an error.
Please check it.
Thank you in advance.

lenaorobei · 2020-04-03T19:59:03Z

app/code/Magento/SampleData/Console/Command/SampleDataDeployCommand.php

     * @return void
     */
    private function updateMemoryLimit()
    {
        if (function_exists('ini_set')) {
-            @ini_set('display_errors', 1);


Please use // phpcs:ignore Magento2.Functions.DiscouragedFunction for the legacy code. ini_alter should be added to the discouraged list as well https://github.com/magento/magento-coding-standard/blob/develop/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php

Hello @lenaorobei
Thank you for your remark.
I have reverted ini_alter to ini_set (without @).
Also, today I am going to add all alias to discouraged functions

magento-engcom-team · 2020-05-22T21:09:31Z

Hi @slavvka, thank you for the review.
ENGCOM-7219 has been created to process this Pull Request

slavvka · 2020-05-27T21:36:28Z

@magento run all tests

slavvka

My mistake

magento-engcom-team · 2020-05-28T19:02:55Z

Hi @slavvka, thank you for the review.
ENGCOM-7219 has been created to process this Pull Request

…ata can't be installed from command line #27481

m2-assistant · 2020-06-05T15:43:41Z

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed issue magento#19481: Magento 2.3.0: After composer installation…

b0c3ead

… sampledata can't be installed from command line

ghost added the Progress: pending review label Mar 28, 2020

magento-engcom-team added Component: SampleData Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 28, 2020

lbajsarowicz approved these changes Mar 28, 2020

View reviewed changes

ghost assigned lbajsarowicz Mar 28, 2020

ghost added Progress: ready for testing and removed Progress: pending review labels Mar 28, 2020

lbajsarowicz approved these changes Mar 28, 2020

View reviewed changes

andrewbess force-pushed the issue-19481 branch 2 times, most recently from 6bbeb54 to 05b1190 Compare March 28, 2020 21:11

andrewbess commented Mar 29, 2020

View reviewed changes

magento/issue#19481: minor and codestyle fixes

7fec913

andrewbess force-pushed the issue-19481 branch from 05b1190 to 7fec913 Compare March 29, 2020 14:15

andrewbess mentioned this pull request Mar 30, 2020

Fixed tests for Magento\Framework\Stdlib\DateTime\DateTime #27492

Merged

4 tasks

Merge branch '2.4-develop' into issue-19481

a24cc81

lbajsarowicz added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 2, 2020

dmytro-ch added Award: bug fix Award: test coverage labels Apr 3, 2020

lenaorobei reviewed Apr 3, 2020

View reviewed changes

ghost assigned lenaorobei Apr 3, 2020

andrewbess added 2 commits April 4, 2020 13:00

Revert from function alias to original function ini_set

a17f104

Fixed tests according to request from issue-27500

2bfb191

andrewbess mentioned this pull request Apr 4, 2020

ISSUE-27500: Fixed unit tests for module Magento_SampleData #27598

Merged

4 tasks

engcom-Alfa self-assigned this Apr 16, 2020

ghost added Progress: ready for testing Progress: testing in progress Progress: extended testing and removed Progress: needs update Progress: ready for testing Progress: testing in progress labels May 22, 2020

slavvka added Progress: testing in progress QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Progress: extended testing labels May 22, 2020

ghost added Progress: accept and removed Progress: testing in progress labels May 27, 2020

Merge branch '2.4-develop' into issue-19481

952d2a9

slavvka requested changes May 27, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: accept labels May 27, 2020

slavvka approved these changes May 28, 2020

View reviewed changes

ghost added Progress: ready for testing Progress: testing in progress Progress: accept and removed Progress: needs update Progress: ready for testing Progress: testing in progress labels May 28, 2020

slavvka mentioned this pull request Jun 5, 2020

Magento 2.3.0: After composer installation sampledata can't be installed from command line #19481

Closed

magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2020

ENGCOM-7219: Fixed issue #19481: After composer installation sample d…

a8e469d

…ata can't be installed from command line #27481

magento-engcom-team merged commit bec39b9 into magento:2.4-develop Jun 5, 2020

andrewbess deleted the issue-19481 branch June 5, 2020 18:40

Fixed issue #19481: After composer installation sample data can't be installed from command line #27481

Fixed issue #19481: After composer installation sample data can't be installed from command line #27481

Uh oh!

Conversation

andrewbess commented Mar 28, 2020 • edited by sdzhepa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Actual result

Result after fix

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Mar 28, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Mar 28, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Mar 28, 2020

Uh oh!

andrewbess Mar 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented May 22, 2020

Uh oh!

slavvka commented May 27, 2020

Uh oh!

slavvka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented May 28, 2020

Uh oh!

m2-assistant bot commented Jun 5, 2020

Uh oh!

Uh oh!

andrewbess commented Mar 28, 2020 •

edited by sdzhepa

Loading

andrewbess Mar 29, 2020 •

edited

Loading

slavvka left a comment •

edited

Loading