Skip to content

[MFTF] Check visibility block only x product left for simple product #27549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2020
Merged

[MFTF] Check visibility block only x product left for simple product #27549

merged 5 commits into from
Jun 18, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 2, 2020 •
edited by m2-assistant bot
Loading

Description (*)

This MFTF test checks visibility only x product left block for simple product
Screenshot 2020-04-02 at 16 52 52

Resolved issues:

  1. resolves [Issue] [MFTF] Check visibility block only x product left for simple product #28755: [MFTF] Check visibility block only x product left for simple product

@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 2, 2020
@rodrigowebjump rodrigowebjump self-requested a review April 5, 2020 02:45
@rodrigowebjump rodrigowebjump self-assigned this Apr 5, 2020
@rodrigowebjump
Copy link
Member

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-27549.instances.magento-community.engineering/admin_32eb
Login: 2437fc6e Password: 0353f67fa15b
Instance will be terminated in up to 3 hours.

@Usik2203
Copy link
Contributor Author

Hi @rodrigowebjump
Any news about this PR ?
Could I kindly ask you to check it If you will have free slot of time
Thank you a lot !

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 3, 2020

@magento run all tests

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 3, 2020

Hi @rogyar Could I kindly ask you to review this PR ?
Thanks.

@rogyar rogyar self-assigned this Jun 5, 2020
rogyar
rogyar requested changes Jun 5, 2020
View reviewed changes
app/code/Magento/Catalog/Test/Mftf/Test/StorefrontOnlyXProductLeftForSimpleProductsTest.xml Outdated
<requiredEntity createDataKey="createCategory"/>
</createData>
<magentoCLI command="config:set {{CatalogInventoryOptionsOnlyXleftThreshold.path}} 10000" stepKey="setStockThresholdQty"/>
<magentoCLI command="cache:flush" stepKey="flushCache"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace flushing the cache with clearing the config cache? Flushing the cache slows down the testing routine significantly every time it's invoked.

Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**Done **

app/code/Magento/Catalog/Test/Mftf/Section/StorefrontProductPageSection.xml Outdated
@@ -25,5 +25,6 @@
<element name="customOptionDropDown" type="select" selector="//*[@id='product-options-wrapper']//select[contains(@class, 'product-custom-option admin__control-select')]"/>
<element name="qtyInputWithProduct" type="input" selector="//tr//strong[contains(.,'{{productName}}')]/../../td[@class='col qty']//input" parameterized="true"/>
<element name="customOptionRadio" type="input" selector="//span[contains(text(),'{{customOption}}')]/../../input" parameterized="true"/>
<element name="onlyProductsLeft" type="block" selector="//div[@class='availability only']"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make the selector of this element more sophisticated. Like, include some parent classes as well. There's a chance of a second element on the page with "availability only" class.

Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rogyar rogyar added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review Award: MFTF test coverage and removed Progress: needs update labels Jun 5, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 8, 2020

@magento run all tests

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 8, 2020

Hi @rogyar
I have applied your code review recommendations
Thanks

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7682 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jun 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Jun 17, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 17, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jun 17, 2020
Closed
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Jun 17, 2020
@engcom-Echo engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jun 17, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 17, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 18, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 18, 2020
@slavvka
ENGCOM-7682: [MFTF] Check visibility block only x product left for si…
9d509fd 
…mple product #27549
@magento-engcom-team magento-engcom-team merged commit ce25297 into magento:2.4-develop Jun 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@rodrigowebjump rodrigowebjump Awaiting requested review from rodrigowebjump

Assignees

@rodrigowebjump rodrigowebjump

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Check visibility block only x product left for simple product
7 participants
@Usik2203 @rodrigowebjump @magento-engcom-team @engcom-Alfa @engcom-Echo @rogyar @slavvka